Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] remove unnecessary json lists from param values #136

Open
mimir-d opened this issue Aug 21, 2022 · 0 comments
Open

[v2] remove unnecessary json lists from param values #136

mimir-d opened this issue Aug 21, 2022 · 0 comments
Assignees
Labels
bug Something isn't working v2_overhaul breaking feature for v2

Comments

@mimir-d
Copy link
Member

mimir-d commented Aug 21, 2022

Currently, all of the parameters are expected to be lists, even when it is unnecessary (like the "binary" below).

{
    "name": "gathercmd",
    "label": "make_logdirs",
    "parameters": {
        "binary": ["mkdir"], <--
        "args": ["-p", "/tmp/control_logs"]
    }
}

There is also some api supporting this Param.GetOne. This should be removed, and the descriptors updated to have single values.
Proposal

{
    "name": "gathercmd",
    "label": "make_logdirs",
    "parameters": {
        "binary": "mkdir", <--
        "args": ["-p", "/tmp/control_logs"]
    }
}
@mimir-d mimir-d added bug Something isn't working v2_overhaul breaking feature for v2 labels Aug 21, 2022
@mimir-d mimir-d self-assigned this Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working v2_overhaul breaking feature for v2
Projects
None yet
Development

No branches or pull requests

1 participant