-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Accessibility #673
Comments
… logo to override value. (#673) Signed-off-by: Chris Abraham <[email protected]>
… logo to override value. (#673) Signed-off-by: Chris Abraham <[email protected]> Signed-off-by: James Hunt <[email protected]>
… logo to override value. (#673) Signed-off-by: Chris Abraham <[email protected]> Signed-off-by: James Hunt <[email protected]>
@cjyabraham Could you have a look at Hubspot to see if we are able to fix the form label issues? I only have CSS control of the embed form it seems - it's inserted via short link:
|
I don't think I can omit the labels. One option, however, is we provide labels but hide them with our own CSS? Or we just skip this one... |
Hubspot allows us to add a label for each form field. I've now added the CSS so that will be hidden (as per the design) and only read for screen readers. Once this PR is merged, we will have to update the footer form with the labels. |
… logo to override value. (#673) Signed-off-by: Chris Abraham <[email protected]> Signed-off-by: James Hunt <[email protected]>
Signed-off-by: James Hunt <[email protected]>
Signed-off-by: James Hunt <[email protected]>
Regarding the tables, I miss-remembered how they were made - I thought they were custom blocks already. But we are using default WordPress tables. This means:
|
Signed-off-by: James Hunt <[email protected]>
Signed-off-by: James Hunt <[email protected]>
Signed-off-by: James Hunt <[email protected]>
@cjyabraham I've added skip link and made the global and event menu keyboard accessible. There's some weirdness with the other-event menu item at the end of the events menu, I can't get it to open, needs more investigation. Do you want to carry on with more things to fix or release this as is, update the hubspot forms, and then re-evaluate? |
Thanks. This sounds like a good stopping point for a release. I'll test it out and have Nicole do the same then we can release. |
When I run WAVE on this page it calls out the image boxes for having empty links. Is that fixable? |
Have you edited the page and re-saved the block? It's JS so I don't think it will update on its own. |
Signed-off-by: James Hunt <[email protected]>
… logo to override value. (#673) Signed-off-by: Chris Abraham <[email protected]> Signed-off-by: James Hunt <[email protected]>
Signed-off-by: James Hunt <[email protected]>
Signed-off-by: James Hunt <[email protected]>
Signed-off-by: James Hunt <[email protected]>
Signed-off-by: James Hunt <[email protected]>
Signed-off-by: James Hunt <[email protected]>
Signed-off-by: James Hunt <[email protected]>
|
@cjyabraham Could you revisit this issue and let me know if there is any further action required? |
No action required at this point but let's keep this open for now since more work is planned and there are some good ideas here. |
Signed-off-by: James Hunt <[email protected]>
Signed-off-by: James Hunt <[email protected]>
Signed-off-by: James Hunt <[email protected]>
Signed-off-by: James Hunt <[email protected]>
Current plan if for James/Chris to start improving the accessibility of the site. Once they've done what they can, we can discuss with Kristin/Angela about making a stronger commitment to accessibility for the site. If we get this we can move forward with publishing an Accessibility Statement, new requirements for incoming event designs/assets, and any further communications.
Improvements needed:
After this initial work, we could follow up with the following:
The text was updated successfully, but these errors were encountered: