Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to disable drive letter on home drive #33

Open
dorianim opened this issue Oct 21, 2021 · 7 comments
Open

Allow to disable drive letter on home drive #33

dorianim opened this issue Oct 21, 2021 · 7 comments
Labels
enhancement New feature or request
Milestone

Comments

@dorianim
Copy link
Member

dorianim commented Oct 21, 2021

Allow to disable drive letter on home drive. This should be done in a config file, and is therefore blocked by #32
This also raises the question if there should also be an option to disable the drive letters in general, also for GPO-mounted drives. (overriding the option in Drives.xml)

@dorianim dorianim added enhancement New feature or request needs confirmation Some more information is needed to confirm the root of the problem labels Oct 21, 2021
@kiarn
Copy link
Member

kiarn commented Oct 22, 2021

Hello Dorian,

Only disable H: in the config file and using useLetter for the other shares is in my opinion not good idea : I think it's easier for the admins to configure all shares in only one file.

By the other hand, if all configuration is done on the linuxclient, it will not be possible to handle this with the Webui.

Arnaud

@dorianim
Copy link
Member Author

Hi Arnaud,

Yes, that's a problem. I think it would be fine to provide an option like disableDriveLetterUsage which just disables the use of drive letters all together and not just for H. Do you think this would be fine for now?

The only clean way for disabling handling only the H letter would be to use some AD attribute, in my opinion. But this would have to be implemented in sophomorix...

@sedding
Copy link

sedding commented Dec 7, 2021

Hej,

"plus one" for the option that turns off all drive letters at one go.

In Linux-environments the windows drive letters are irrelevant and even if one would like to have them, he would like have all of them...
IMHO a option that turns off drive letter usage is completely sufficient - all or none - not at least for consistency reasons.

@dorianim
Copy link
Member Author

dorianim commented Dec 7, 2021

Yes, I agree. But as I already mentioned, #32 has to be resolved first.

@dorianim dorianim removed the needs confirmation Some more information is needed to confirm the root of the problem label Jan 1, 2022
@jolly-jump
Copy link

Can you point me to where (H:) is hardcoded? I can't find it in the source of this repo. Maybe I just don't know my regexp. 🤷 ?
Thanks

@dorianim
Copy link
Member Author

shareName = f"{usernameString} ({userAttributes['homeDrive']})"

H is not actually hardcoded. It is and ldap attribute.

@jolly-jump
Copy link

thanks. Yes, makes sense.
I changed that line for me to as a workaround

shareName = f"Home_auf_Server von {usernameString}"

@dorianim dorianim added this to the 1.1.0 milestone Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants