Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] beetcamp Plugin causing nightly builds to install 1.6.0 of beets rather than current upstream. #129

Closed
1 task done
BGarber42 opened this issue Oct 21, 2024 · 2 comments

Comments

@BGarber42
Copy link

BGarber42 commented Oct 21, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

Beets 2.0.0 is downgraded to 1.6.0

Expected Behavior

Beets 2.0.0 is installed

Steps To Reproduce

  1. Build nightly branch

Environment

- OS: Unraid
- How docker service was installed: Distro

CPU architecture

x86-64

Docker creation

docker run
  -d
  --name='beets'
  --net='bridge'
  -e TZ="America/New_York"
  -e HOST_OS="Unraid"
  -e HOST_HOSTNAME="Tower"
  -e HOST_CONTAINERNAME="beets"
  -e 'DOCKER_MODS'='linuxserver/mods:universal-package-install'
  -e 'INSTALL_PIP_PACKAGES'='git+https://github.com/x1ppy/beets-originquery|git+https://github.com/x1ppy/gazelle-origin'
  -e 'INSTALL_PACKAGES'='git'
  -e 'PUID'='99'
  -e 'PGID'='100'
  -e 'UMASK'='022'
  -l net.unraid.docker.managed=dockerman
  -l net.unraid.docker.webui='http://[IP]:[PORT:8337]'
  -l net.unraid.docker.icon='https://raw.githubusercontent.com/linuxserver/docker-templates/master/linuxserver.io/img/beets-logo.png'
  -p '8337:8337/tcp'
  -v '/mnt/user/data/media/':'/music':'rw'
  -v '/mnt/user/data/':'/downloads':'rw'
  -v '/mnt/user/appdata/beets':'/config':'rw' 'lscr.io/linuxserver/beets:nightly'

Container logs

https://ci.linuxserver.io/blue/organizations/jenkins/Docker-Pipeline-Builders%2Fdocker-beets/detail/nightly/1390/pipeline/155/#step-166-log-734

Upstream package reqs: https://github.com/snejus/beetcamp/blob/main/pyproject.toml#L30

@thespad
Copy link
Member

thespad commented Oct 22, 2024

I suspect this doesn't happen with the stable build because we install beets==2.0.0 with the same pip command as beetcamp and so it finds an older version of beetcamp that's compatible

#10 33.37 INFO: pip is looking at multiple versions of beetcamp to determine which version is compatible with other requirements. This could take a while.
#10 33.37 Collecting beetcamp
#10 33.50   Downloading beetcamp-0.19.2-py3-none-any.whl.metadata (15 kB)

Whereas with nightly we build beets from source, then install beetcamp afterwards.

We could remove it entirely, or we could pin it to 0.19.2 until upstream is fixed, which might be preferable.

@thespad thespad mentioned this issue Oct 22, 2024
1 task
@thespad
Copy link
Member

thespad commented Oct 22, 2024

Pushed a new build with beetcamp pinned to the previous version so it won't try and force an old beets install. Will revisit once beetcamp fix their requirements.

@thespad thespad closed this as completed Oct 22, 2024
@LinuxServer-CI LinuxServer-CI moved this from Issues to Done in Issue & PR Tracker Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

2 participants