Skip to content
This repository has been archived by the owner on Apr 22, 2019. It is now read-only.

Build broken because of upstream apk issue in libxslt #1

Closed
vielmetti opened this issue Apr 1, 2017 · 11 comments
Closed

Build broken because of upstream apk issue in libxslt #1

vielmetti opened this issue Apr 1, 2017 · 11 comments

Comments

@vielmetti
Copy link

The Jenkins build is breaking for this repo

http://jenkins.linuxserver.io:8080/job/Dockers/job/LinuxServer.io-arm64/job/lsioarm64-nginx/6/

because of this upstream bug in Alpine Linux

https://bugs.alpinelinux.org/issues/7082

in the libxslt library:

libxslt, libxslt-dev package version mismatch in index and file url

On repository - 1.1.29-r1
http://dl-4.alpinelinux.org/alpine/v3.5/main/aarch64/libxslt-1.1.29-r1.apk

On index - 1.1.29-r0
http://dl-4.alpinelinux.org/alpine/v3.5/main/aarch64/APKINDEX.tar.gz

@aptalca
Copy link
Member

aptalca commented Apr 1, 2017

Thanks, that affected quite a few of our builds. We are applying a temporary fix. In the meantime, do you mind reporting it to alpine linux since it's a larger upstream issue in their end?

@vielmetti
Copy link
Author

Yup, it's reported to Alpine at https://bugs.alpinelinux.org/issues/7082 - if you can chime in there that would probably help track it.

@vielmetti
Copy link
Author

I have an idea (but not confirmed) that this is CVE-2017-5029.

@vielmetti
Copy link
Author

Build looks like it's fixed, based on

http://jenkins.linuxserver.io:8080/job/Dockers/job/LinuxServer.io-arm64/job/lsioarm64-nginx/8/

I'll keep tracking this upstream.

@vielmetti
Copy link
Author

vielmetti commented Apr 2, 2017

While I'm here, are you building nginx with an SSL library that has arm64 hardware acceleration instruction support? I don't know if the hardware you are targeting has that in it, but there's opportunity for substantial (4x-16x) performance. (edited)

@sparklyballs
Copy link
Contributor

@aptalca ^^^

@vielmetti
Copy link
Author

@aptalc @sparklyballs I ask about arm64 asm because of this

https://bugs.launchpad.net/ubuntu/+source/openssl/+bug/1552939

which says that the asm support was patched into Debian but not upstreamed. Their suggested benchmark is openssl speed -evp aes-128-gcm. The compare would be Debian or Ubuntu vs Alpine.

@aptalca
Copy link
Member

aptalca commented Apr 3, 2017

@vielmetti we are using the 3.5 repo version of openssl, which is 1.0.2k. It gets pulled during the nginx baseimage build: http://jenkins.linuxserver.io:8080/job/Dockers/job/BaseImages-arm64/job/lsiobase-alpine.nginx.arm64/lastSuccessfulBuild/console

At first look, it doesn't seem like asm is enabled. Here's their source and apkbuild: https://github.com/alpinelinux/aports/blob/3.5-stable/main/openssl/APKBUILD

@vielmetti
Copy link
Author

vielmetti commented Apr 3, 2017

@aptalca - I did some rudimentary tests and I think the 3.5 repo version of openssl is fine.

My test benchmark is openssl speed -evp aes-128-gcm

On my Packet 2A (Cavium ThunderX) machine, aarch64/alpine:

type             16 bytes     64 bytes    256 bytes   1024 bytes   8192 bytes
aes-128-gcm      75927.03k   159637.95k   236105.30k   267744.94k   277872.64k

Same machine, Ubuntu 16.04 LTS native, not in a container:

type             16 bytes     64 bytes    256 bytes   1024 bytes   8192 bytes
aes-128-gcm      78725.55k   167274.09k   239925.42k   267936.77k   277779.80k

Funny enough, the aarch64/debian image is pretty bad:

Same machine, aarch64/debian Docker container:

type             16 bytes     64 bytes    256 bytes   1024 bytes   8192 bytes
aes-128-gcm      34259.34k    39121.77k    40780.29k    41207.47k    41394.18k

Now to figure out upstream where I can report this Debian performance bug! (But you're good.)

@vielmetti
Copy link
Author

Update on the original bug:

https://bugs.alpinelinux.org/issues/7082

it looks like the index has been fixed, can you retry your original build without the edge config, @aptalca @sparklyballs ?

@aptalca
Copy link
Member

aptalca commented Oct 1, 2017

This was resolved a while back. Forgot to close

@aptalca aptalca closed this as completed Oct 1, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants