Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Enterprise support #16

Open
TheJaredWilcurt opened this issue Jan 26, 2015 · 11 comments
Open

GitHub Enterprise support #16

TheJaredWilcurt opened this issue Jan 26, 2015 · 11 comments

Comments

@TheJaredWilcurt
Copy link

You have the github website hardcoded. It would be nice if there was an options page for users to add in custom URLs/domains for this to work on. Many companies have the enterprise version of GitHub and being able to search the wiki at work would be super useful.

If nothing else, you could just add in a regex thing to look for http(s)://githib.*.com/*/*/wiki

  function allowedLocation(callback) {
    if (/^https?:\/\/github\.com\/.*?\/.*?\/wiki/.test(location.href)) {
      callback();
    }
  }
@soasme
Copy link

soasme commented Feb 12, 2015

+1

1 similar comment
@ccampanale
Copy link

+1

@ccampanale
Copy link

In the meantime, I made this. I'm still testing it to ensure it isn't breaking anything but it seems to be working as intended until the extension can include support for GHE installations.

@ccampanale
Copy link

I agree with @TheJaredWilcurt though I think a better regex would be /^https?:\/\/github\..*?\/.*?\/.*?\/wiki/ as this would return true for both public and enterprise GitHub installations. That being said, I believe the real limitation here is in the manifest of the Chrome extension as you have to define on which sites you want the script to run. Though I may be wrong!

@judwhite
Copy link

judwhite commented Jul 6, 2015

+1, though our subdomain contains 'github' it doesn't start with it.

@kleinen
Copy link

kleinen commented Mar 16, 2016

+1

@TheJaredWilcurt
Copy link
Author

Really the correct answer is to just let people type in the root for their own github server, even if it's just localhost:8080.

Though, auto-guessing would be cool too.

@ccampanale
Copy link

Hrmmm we never closed this issue... lol

This is done and it's a feature now for anyone who is curious. And you can do exactly that @TheJaredWilcurt; there's an options page that lets you define for which domains you want the extension to run on.

@TheJaredWilcurt
Copy link
Author

@ccampanale

I just downloaded the extension and tried it on both github and ghe, and neither worked. There's also no options page.

options

@kleinen
Copy link

kleinen commented Mar 16, 2016

I also am unable to find the options you refer to.

@ccampanale
Copy link

Guys, my bad... I got the extension mixed up; I was thinking this was another one that I contributed to that recently got enterprise support... :-/ This one unfortunately still has no support for enterprises... :( Sorry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants