Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in equation (C2) (table3) of the paper #15

Open
raphael-kinvi opened this issue Feb 15, 2022 · 1 comment
Open

Bug in equation (C2) (table3) of the paper #15

raphael-kinvi opened this issue Feb 15, 2022 · 1 comment

Comments

@raphael-kinvi
Copy link

Hello,
Apparently there is a typo in the related LIONSIMBA paper regarding the FVM discretization of the LHS of the electrolyte potential equation (C2). It seems that you miss a multiplication by (-).
Thank you for this great job.
@lionsimbatoolbox
Copy link
Owner

Hello.

Thanks for pointing this out. I'll double-check, and add a typo notice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lionsimbatoolbox @raphael-kinvi