From 427477a231cee930cb466df895c96f482ea1782e Mon Sep 17 00:00:00 2001 From: Gustav Munkby Date: Thu, 9 Nov 2023 14:34:12 +0100 Subject: [PATCH] Ensure ErrorResponse is cleared between PollForErrorResponse runs --- archive/control.go | 2 ++ archive/control_test.go | 1 - 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/archive/control.go b/archive/control.go index 64f0b059..7a001654 100644 --- a/archive/control.go +++ b/archive/control.go @@ -349,6 +349,8 @@ func (control *Control) PollForErrorResponse() (int, error) { context := PollContext{control, 0} received := 0 + control.Results.ErrorResponse = nil + // Poll for async events, errors etc until the queue is drained for { ret := control.poll( diff --git a/archive/control_test.go b/archive/control_test.go index 0c9b7322..95fb2209 100644 --- a/archive/control_test.go +++ b/archive/control_test.go @@ -127,7 +127,6 @@ func TestControl_PollForErrorResponse(t *testing.T) { cnt, err := control.PollForErrorResponse() assert.EqualValues(t, 1, cnt) assert.Error(t, err) - control.Results.ErrorResponse = nil // TODO: Should this really be necessary? cnt, err = control.PollForErrorResponse() assert.EqualValues(t, 1, cnt) assert.NoError(t, err)