Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weird behaviours in the properties filter with filtering with a search text #479

Open
NicolasMahe opened this issue Nov 21, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@NicolasMahe
Copy link
Member

I notice two weird behaviours in the properties filter with filtering with a search text

Blinking behaviour in properties filter with search text

When I search for a property using the search input, and select a property, there is a weird blinking behaviour:

Screen.Recording.2023-11-21.at.09.39.48.mov

For info, before PR #477, after selecting a property, the search input filter was not applied anymore, so PR #477 already improve this. You can test using https://nft-test-uaan-9hu4d9j0h-liteflow.vercel.app/explore.

It seems the variable propertySearch is reset to undefined quickly after selecting a property, and then filled back to its previous value. I notice this is not always the case, sometime, propertySearch stays undefined.

Filtered properties are not always selected

When I put a search text, then select a property, and then change the search text, it some times "unselect" the property. Putting back the same search text when I selected the property, re-select the property, but some time it works fine:

Screen.Recording.2023-11-21.at.09.52.02.mov
@NicolasMahe NicolasMahe added the bug Something isn't working label Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant