Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: ExistsFilter #331

Open
riyavsinha opened this issue Jan 11, 2025 · 1 comment · May be fixed by #336
Open

Enhancement: ExistsFilter #331

riyavsinha opened this issue Jan 11, 2025 · 1 comment · May be fixed by #336
Assignees
@cofin
Labels
accepted Change or enhancement is accepted for development. enhancement New feature or request

Comments

@riyavsinha
Copy link

Summary

It would be great to be able to specify something like:

variants_not_scored_by_model = await model_score_repo.list(
            CollectionFilter(models.ModelScores.variant_id, variant_ids),
            ~exists().where(
                and_(
                    models.ModelScores.model_id == model_id,
                    models.ModelScores.variant_id == models.Variant.id,
                )
            )
        )

As far as I know, there is no exists filter, and I'm not sure the above doesn't work. Essentially, if an ExistsFilter could take in a sublist of StatementFilters that would be nice.

Basic Example

variants_not_scored_by_model = await model_score_repo.list(
            CollectionFilter(models.ModelScores.variant_id, variant_ids),
            NotExistsFilter(
                    models.ModelScores.model_id == model_id,
                    models.ModelScores.variant_id == models.Variant.id,
            )
        )

Drawbacks and Impact

No response

Unresolved questions

No response
@riyavsinha riyavsinha added the enhancement New feature or request label Jan 11, 2025
@cofin cofin added the accepted Change or enhancement is accepted for development. label Jan 11, 2025
@cofin cofin self-assigned this Jan 11, 2025
@cofin
Copy link
Member

cofin commented Jan 11, 2025

@riyavsinha I think there is some value to have some filters for this. I'll try to get this added in an upcoming release.

Regarding your first question, you should be able to do something close to what your want The args of the repository will accept a StatementFilter or a ColumnElement[bool] (a where clause in SQLAlchemy)

Here's a basic example of mixing Statement Filters and ColumnExpressions into a single set of filters.

filters = [CollectionFilter(models.TeamModel.groups, country_code_groups), Team.is_deleted == False],
if not teams_service.can_view_all(current_user):
  filters.append(
     TeamModel.id.in_(
        select(TeamMemberModel.team_id).where(TeamMemberModel.user_id == current_user.id)
     )
 ) 

results, total = await teams_service.list_and_count(*filters)

You can also mix and match the kwargs and args. For the repository, all kwargs keywords are automatically converted to ColumnElement[bool] and applied to the statement:

results, total = await teams_service.list_and_count(*filters, is_active=True)

cofin added a commit that referenced this issue Jan 11, 2025
@cofin
feat(filters): adds an ExistsFilter and NotExists filter
0edc57c 
Fixes #331
This was referenced Jan 11, 2025
Closed
Draft
cofin added a commit that referenced this issue Jan 11, 2025
@cofin
feat(filters): adds an ExistsFilter and NotExists filter
6631360 
Fixes #331
cofin added a commit that referenced this issue Jan 11, 2025
@cofin
feat(filters): adds an ExistsFilter and NotExists filter
4992681 
Fixes #331
cofin added a commit that referenced this issue Jan 20, 2025
@cofin
feat(filters): adds an ExistsFilter and NotExists filter
95db198 
Fixes #331
cofin added a commit that referenced this issue Jan 20, 2025
@cofin
feat(filters): adds an ExistsFilter and NotExists filter
21826ca 
Fixes #331
cofin added a commit that referenced this issue Jan 21, 2025
@cofin
feat(filters): adds an ExistsFilter and NotExists filter
3e98e43 
Fixes #331
cofin added a commit that referenced this issue Jan 21, 2025
@cofin
feat(filters): adds an ExistsFilter and NotExists filter
758c327 
Fixes #331
cofin added a commit that referenced this issue Jan 26, 2025
@cofin
feat(filters): adds an ExistsFilter and NotExists filter
4dcf739 
Fixes #331
@Kumzy Kumzy mentioned this issue Jan 30, 2025
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cofin cofin

Labels
accepted Change or enhancement is accepted for development. enhancement New feature or request
Projects
None yet
Milestone
No milestone
2 participants
@cofin @riyavsinha