Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove illegal absolute UnixFS symlinks #89

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

John-LittleBearLabs
Copy link
Collaborator

Removing code for
absolute symlinks
which point outside root.

Fixes #85

Copy link

codecov bot commented Dec 15, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (5e41a17) 52.45% compared to head (190e2d1) 62.21%.
Report is 16 commits behind head on main.

Files Patch % Lines
library/include/ipfs_client/gw/requestor.h 0.00% 2 Missing ⚠️
library/include/multibase/algorithm.h 33.33% 2 Missing ⚠️
library/include/ipfs_client/cid.h 50.00% 1 Missing ⚠️
library/include/ipfs_client/context_api.h 0.00% 1 Missing ⚠️
library/include/ipfs_client/dag_cbor_value.h 0.00% 1 Missing ⚠️
library/include/ipfs_client/gateways.h 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #89      +/-   ##
==========================================
+ Coverage   52.45%   62.21%   +9.75%     
==========================================
  Files          48       71      +23     
  Lines        2381     2911     +530     
==========================================
+ Hits         1249     1811     +562     
+ Misses       1132     1100      -32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Removing code for
absolute symlinks
which point outside root.
@John-LittleBearLabs John-LittleBearLabs merged commit 3c3946a into main Jan 17, 2024
7 checks passed
@John-LittleBearLabs John-LittleBearLabs deleted the symlinkinrootonly branch January 17, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Symlinks may not point outside DAG root
2 participants