Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight #34

Open
littlewhitecloud opened this issue Jun 12, 2023 · 9 comments
Open

Highlight #34

littlewhitecloud opened this issue Jun 12, 2023 · 9 comments
Labels
enhancement New feature or request

Comments

@littlewhitecloud
Copy link
Owner

Is your feature request related to a problem? Please describe.
No
Describe the solution you'd like
Add highlight to the terminal widget, just like
image

Additional context
None

@littlewhitecloud littlewhitecloud added the enhancement New feature or request label Jun 12, 2023
@Moosems
Copy link
Collaborator

Moosems commented Jun 12, 2023

What?

@littlewhitecloud
Copy link
Owner Author

I mean we can add a highlight to the terminal widget.

@Moosems
Copy link
Collaborator

Moosems commented Jun 12, 2023

Maybe an optional arg?

@littlewhitecloud
Copy link
Owner Author

Maybe an optional arg?

Maybe... But I prefer to use it as default.

@Moosems
Copy link
Collaborator

Moosems commented Jun 12, 2023

An arg to turn it off then? I personally want to be able to use a terminal as similar to the one that comes natively to Mac as possible but I like your ideas a lot and want this to be able to be added and able to be turned off for those who don't want it.

@littlewhitecloud
Copy link
Owner Author

An arg to turn it off then? I personally want to be able to use a terminal as similar to the one that comes natively to Mac as possible but I like your ideas a lot and want this to be able to be added and able to be turned off for those who don't want it.

I mean:

class Terminal(Frame):
    "abab"
    def __init__(self, abab, abab, abab, highlight: bool = True) # Default the highlight arg is true, but if you like, you can give false
   --snip--

@littlewhitecloud
Copy link
Owner Author

Fine, nvm, maybe we can put autohidescrollbar and highlight and other enhancements into an option to enable them.

@littlewhitecloud
Copy link
Owner Author

To some user, maybe they want to keep the terminal light. Or save memory.

@Moosems
Copy link
Collaborator

Moosems commented Jun 22, 2023

I personally want it as similar to the defaults you find on the average OS but allow more options as extras.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants