-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow devendoring of spdlog #60
Comments
Ok, makes sense, but do you have any advice about what to do for Windows, then? |
Yeah, Windows is always a bit of a special case, I guess. ;-) My proposal is to allow devendoring, not to enforce it. For environments such as Windows it could still remain vendored. However, other operating systems such as Linux have different requirements. If allowing to use a system version of spdlog is done via a CMake option (e.g. Closing, I guess it would also be great to upgrade the vendored version (to remain in sync with its upstream). |
@dvzrv , ok, I have put the change in the branch I have also updated the bundled spdlog in that branch to make it compatible with the one I see packaged for my Linux distribution, so that I can use the same source code in the application. If this is what you were looking for, I'll merge into master and tag a new release. |
Argh, sorry... I forgot about this ticket! |
Okay, I have commented on a small issue with the fix. Unfortunately we are already at spdlog 1.7.0 and building against it does not work: |
Hi! I'm maintaining osmid for Arch Linux.
As on most Linux distributions, we already have spdlog (and in a much newer version) it would be great to allow proper devendoring of the library (e.g. via CMake option).
Vendoring (aka bundling) of libraries (especially very old ones) is never a good idea. Fedora has a good writeup as to why that is.
The spdlog library offers both pkgconfig and cmake integration out-of-the-box, so discovery and integration of a system version should be trivial.
The text was updated successfully, but these errors were encountered: