From 525445ea0fd9f45017ab3600d2598f2d46352bdd Mon Sep 17 00:00:00 2001 From: Lluis Date: Tue, 13 Feb 2024 16:52:07 +0100 Subject: [PATCH] add logs and check browser exists before checking process() --- helpers/browserApi.js | 3 ++- services/browser.js | 2 ++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/helpers/browserApi.js b/helpers/browserApi.js index a5b7ccc..f9fdbbc 100644 --- a/helpers/browserApi.js +++ b/helpers/browserApi.js @@ -17,8 +17,9 @@ class PuppeteerApi { async createNewBrowser() { this.browser = await puppeteer.connect({ browserWSEndpoint: config.browserlessUrl }) this.browser.on('disconnected', async () => { + console.log('disconnected browser') if (this.browser) await this.browser.close() - if (this.browser.process() != null) this.browser.process().kill('SIGINT') + if (this.browser && this.browser.process() != null) this.browser.process().kill('SIGINT') this.browser = null }) } diff --git a/services/browser.js b/services/browser.js index 5fb6f6b..d8bf1b3 100644 --- a/services/browser.js +++ b/services/browser.js @@ -30,10 +30,12 @@ async function startAndWarmUpBrowserIfNeeded() { const browserIsOpen = await browserApi.checkIfBrowserIsOpen() if (!browserIsOpen) { + console.log('Browser is not open, creating new one') await browserApi.createNewBrowser() } const pageIsOpen = await browserApi.checkIfPageIsOpen() if (!pageIsOpen) { + console.log('Page is not open, creating new one') await browserApi.createNewPage() } }