[libc++] Remove the pointer safety functions from the dylib #117390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philnik777
force-pushed
the
remove_legacy_pointer_safety
branch
from
cad8482
to
05b714f
Compare
philnik777
force-pushed
the
remove_legacy_pointer_safety
branch
from
05b714f
to
8881a95
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pointer safety functions were never implemented by anyone in a non-trivial way, which lead us to removing them entirely from the headers when they were removed in C++23. This also means that just about nobody ever called these functions, especially not in production code. Because of that, we expect there to be no references in the wild to the functions in the dylib. Because of that, this patch removes the symbols from the dylib.