Use lld on clang-aarch64-full-2stage #281
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have another bot that uses lld, linaro-clang-aarch64-lld-2stage. However it does not build flang or mlir. I don't think we really need both, so I've added the lld settings to clang-aarch64-full-2stage as well. If this is stable then we can remove linaro-clang-aarch64-lld-2stage.
DavidSpickett
force-pushed
the
use-lld
branch
from
02a5785
to
7172116
Compare
omjavaid
reviewed
Oct 17, 2024
| '--threads=32', '--build-threads=32'], | ||
| extra_cmake_args=[ | ||
| "-DCMAKE_C_FLAGS='-mcpu=cortex-a57'", | ||
| "-DCMAKE_CXX_FLAGS='-mcpu=cortex-a57'", | ||
| "-DLLVM_ENABLE_LLD=True", | ||
| "-DLLVM_LIT_ARGS='-v'", |
There was a problem hiding this comment.
I guess we should use -DCLANG_DEFAULT_LINKER=lld but I am little unsure about what -DLLVM_ENABLE_LLD=True does.
Also now that we are making changes to this builder, let change the cpu setting as well. I guess this will run on AWS which may use -mcpu=neoverse-v1 or something similar?
There was a problem hiding this comment.
Ampere Mountain Jade something but yes we should do that anyway I'll do that in a new PR.
luporl
reviewed
Oct 17, 2024
|
True. Let me check what the SVE bots do right now. If those are all lld or close to it, maybe we keep this one using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have another bot that uses lld, linaro-clang-aarch64-lld-2stage. However it does not build flang or mlir.
I don't think we really need both, so I've added the lld settings to clang-aarch64-full-2stage as well.
If this is stable then we can remove linaro-clang-aarch64-lld-2stage.