Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing support for Django 5.1 #40

Closed
mliezun opened this issue Sep 13, 2024 · 5 comments · Fixed by #42
Closed

Failing support for Django 5.1 #40

mliezun opened this issue Sep 13, 2024 · 5 comments · Fixed by #42

Comments

@mliezun
Copy link

mliezun commented Sep 13, 2024

Hi!

Thanks for the project.

I was trying to use it with Django 5.1 and got the following error:

Because drf-recaptcha (4.0.1) depends on django (>=4.2,<5.0)
 and <project> depends on django (5.1.0), drf-recaptcha is forbidden.
So, because <project> depends on drf-recaptcha (4.0.1), version solving failed.

Here's a copy of my dependencies:

[tool.poetry.dependencies]
python = "^3.11"
django = "5.1.0"
whitenoise = "^6.7.0"
psycopg2-binary = "^2.9.9"
django-admin-env-notice = "^1.0"
django-environ = "^0.11.2"
django-structlog = "^8.1.0"
django-recaptcha = "^4.0.0"
django-templated-mail = "^1.1.1"
djangorestframework = "^3.15.2"
backoff = "^2.2.1"
python-dateutil = "^2.9.0.post0"
gunicorn = "^23.0.0"
django-health-check = "^3.18.3"
drf-recaptcha = "4.0.1"
@KOliver94
Copy link
Contributor

KOliver94 commented Sep 14, 2024

I'd say this line is the problem as caret requirements only allow until the next major version which is < 5.0 in this case.

django = "^4.2"

I think django = ">= 4.2" should work.

@llybin
Copy link
Owner

llybin commented Sep 14, 2024

Thanks for the information. You're probably right. I'll try to fix it today or tomorrow

@mliezun
Copy link
Author

mliezun commented Sep 14, 2024

I made a PR #41 to make it easier for you @llybin.

@llybin llybin linked a pull request Sep 15, 2024 that will close this issue
llybin added a commit that referenced this issue Sep 15, 2024
* #40 fix pyproject dependencies

* bump version
@mliezun
Copy link
Author

mliezun commented Sep 15, 2024

Thank you @llybin!!

@llybin
Copy link
Owner

llybin commented Sep 15, 2024

@mliezun, thank you, have a nice Monday :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants