New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect proper method casing #14

Open

OndraM opened this issue Apr 13, 2018 · 0 comments

Labels

Member

OndraM commented Apr 13, 2018 •

edited

Loading

Codestyle should detect when wrong casing (which differs from parent class/interface) is used.
https://github.com/lmc-eu/matej-client-php/pull/72/files/81f858f6395a328912b2d46e9adfb0c02641ef10#diff-ad0bc5361b920e3a3e22dce7973789a4R18

class MyTest extends PHPUnit\Framework\TestCase
    protected function setup(): void { // should be setUp
    ...
    }
}

I've seen some check for this, not sure where it was 🙈 .

OndraM added the enhancement label

OndraM mentioned this issue

Fix failing intergration test (RAD-1066) lmc-eu/matej-client-php#72

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment