Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Table selector fails on Heasarc #150

Open
lmichel opened this issue Jan 25, 2022 · 5 comments · Fixed by #161
Open

[Bug] Table selector fails on Heasarc #150

lmichel opened this issue Jan 25, 2022 · 5 comments · Fixed by #161
Labels
bug Something isn't working fixed in dev the issue is fixed in the dev branch

Comments

@lmichel
Copy link
Owner

lmichel commented Jan 25, 2022

Describe the bug
service : //heasarc.gsfc.nasa.gov/xamin/vo/tap

the table selector does not work likely due to some bad encoded char in the query (;
 likely)
Screenshot 2022-01-25 at 23 04 19

Th issue might go away if the \n is preceded by a space.

@lmichel lmichel added the bug Something isn't working label Jan 25, 2022
@galyfray
Copy link
Collaborator

almost everything doesn't work with this service it doesn't handle even simple joins ...

@lmichel
Copy link
Owner Author

lmichel commented Jan 27, 2022

When you run the table selector on that service with e.g.EIN as string pattern, you execute the following query string

SELECT TOP 500 TAP_SCHEMA.tables.table_name AS noField, TAP_SCHEMA.tables.schema_name AS schemaName, 
TAP_SCHEMA.tables.description AS tableDesc, TAP_SCHEMA.schemas.description AS schemDesc, 
TAP_SCHEMA.tables.table_name AS tableName 
FROM TAP_SCHEMA.tables 
WHERE ( ( UPPER(TAP_SCHEMA.tables.table_name) LIKE '%EIN%' ) )

The is a missing join between TAP_SCHEMA.tables and TAP_SCHEMA.schemas

@galyfray
Copy link
Collaborator

yes that's somehow half expected. As said earlier this services doesn't event support simple joins thus the API register no joins at all. The search bar can't work properly this way and thus should be disabled in such cases

@lmichel
Copy link
Owner Author

lmichel commented Jan 27, 2022

OK, but it runs wrong queries!
in this case the search tool should be replaced with an alert like: Sorry GUY

@galyfray galyfray added the fixed in dev the issue is fixed in the dev branch label Feb 2, 2022
galyfray added a commit that referenced this issue Feb 2, 2022
galyfray added a commit that referenced this issue Feb 3, 2022
* Resolves #155 
* Resolves #156
* Resolves #153 
* Resolves #150
* Improved `getSubTables`'s performance
* fixed some services not recognizing the requests parameters
@lmichel
Copy link
Owner Author

lmichel commented Feb 3, 2022

still not working , error 400 in the console but nothing on the screen
Screenshot 2022-02-03 at 13 37 38

@lmichel lmichel reopened this Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed in dev the issue is fixed in the dev branch
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants