Skip to content
This repository has been archived by the owner on Jul 19, 2023. It is now read-only.

UX: Add some checks to receiving lightning payments offchain #47

Open
nolim1t opened this issue Oct 19, 2019 · 2 comments
Open

UX: Add some checks to receiving lightning payments offchain #47

nolim1t opened this issue Oct 19, 2019 · 2 comments
Labels
enhancement New feature or request

Comments

@nolim1t
Copy link
Member

nolim1t commented Oct 19, 2019 •
edited
Loading

Some basic checks to the API endpoint like:

  • No channels open (so its kindof pointless to proceed)
  • Not enough inbound liquidity

The endpoint shouldn't really be generating invoices that can't be paid for.
@nolim1t nolim1t added the enhancement New feature or request label Oct 19, 2019
@meeDamian
Copy link
Member

I agree. The biggest issue are:

  • time to do it,
  • invoicer needs new permissions, although I think it can be addressed with macaroon bakery being intro'ed in v0.9.0.

@nolim1t
Copy link
Member Author

nolim1t commented Mar 11, 2020

Or we can expose some more endpoints and have the frontend do this?

One for channels would be nice

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nolim1t @meeDamian