Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On-demand backup only when channel state changes #22

Open
meeDamian opened this issue Apr 22, 2019 · 4 comments
Open

On-demand backup only when channel state changes #22

meeDamian opened this issue Apr 22, 2019 · 4 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed question Further information is requested

Comments

@meeDamian
Copy link
Member

See: https://gist.github.com/alexbosworth/2c5e185aedbdac45a03655b709e255a3

Is the image the place to incorporate backups?

Theoretically, the final stage here could also trigger backups after each new channel open, and always write a new backup file to an extra volume.

Alternatively, the host system does it since all necessary files are in an exposed volume already.

I think I'd lean towards the host OS handling it.

@AnotherDroog
Copy link
Member

I think I'd lean towards the host OS handling it.

100%

I'm going to check that we have inotify, that's better than polling.

Otherwise, doesn't LND have an API endpoint that can notify us of changes requiring a new backup?

@nolim1t
Copy link
Member

nolim1t commented Apr 23, 2019

It doesn’t I believe.. maybe we can ask the lnd guys

@meeDamian
Copy link
Member Author

Honestly, I didn't think that this endpoint existed… But it does: https://github.com/lightningnetwork/lnd/blob/master/lnrpc/rpc.proto#L760-L770 :) That's pretty cool!

Still, that belongs to some management utility, and not this general container. Let's close/move the issue.

@AnotherDroog AnotherDroog transferred this issue from lncm/docker-lnd Apr 25, 2019
@AnotherDroog AnotherDroog added enhancement New feature or request help wanted Extra attention is needed question Further information is requested labels Apr 25, 2019
@AnotherDroog
Copy link
Member

Backup functionality makes sense as a manual CLI command and API function of noma.

Details could use further discussion

@AnotherDroog AnotherDroog changed the title Backup On-demand backup only when channel state changes Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed question Further information is requested
Projects
None yet
Development

No branches or pull requests

5 participants