Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added block, unblock and blocklist commands #603

Closed
wants to merge 0 commits into from

Conversation

jgosmus
Copy link
Contributor

@jgosmus jgosmus commented Nov 3, 2024

Pull request to close #438 issue

@knocte
Copy link
Contributor

knocte commented Nov 3, 2024

Hey @jgosmus thanks for your PR!

Hate to be that guy, but you didn't respect the CONTRIBUTING rules, where it says that all new files should be TypeScript (.ts extension), not JS :)

@grunch
Copy link
Member

grunch commented Nov 4, 2024

Pull request to close #438 issue

Hi @jgosmus you did a great work thank you, but it is true, we are working on a migration to TypeScript since long time, that's why all new code should be on typescript, another recommendation is can you split this PR on smaller ones? that way is easier to review and test.

@jgosmus
Copy link
Contributor Author

jgosmus commented Nov 17, 2024

Hello!
Of course, I will migrate the PR to TS, no problem for that!

About splitting the PR, I don't know how many PR would you want?

Maybe I can split it in two:

  • For the new commands /block, /unblock and /blocklist
  • Make the commands take effect

The first one would add the commands but not the checks needed when you pick an offer (check if any of the two users are blocked)

The second one would include those checks and the messages to inform the user

The first one could be split in three (one per command) if you need it!

@grunch
Copy link
Member

grunch commented Nov 19, 2024

Hello! Of course, I will migrate the PR to TS, no problem for that!

About splitting the PR, I don't know how many PR would you want?

Maybe I can split it in two:

* For the new commands /block, /unblock and /blocklist

* Make the commands take effect

The first one would add the commands but not the checks needed when you pick an offer (check if any of the two users are blocked)

The second one would include those checks and the messages to inform the user

The first one could be split in three (one per command) if you need it!

Awesome, feel free on split the PR on two or three, but try to make it in a way that would be easier to review, and thank you for migrating it to TS 😃

@jgosmus jgosmus closed this Nov 24, 2024
@jgosmus jgosmus force-pushed the implement_block_command branch from 7c1bb27 to 4b278ce Compare November 24, 2024 15:21
@knocte
Copy link
Contributor

knocte commented Nov 25, 2024

@jgosmus closed by mistake?

@jgosmus
Copy link
Contributor Author

jgosmus commented Nov 25, 2024

Yeah, It was closed automatically, I guess it closed because I am modifying the commits in my repository, but no problem, I will open the splitted pull requests we talked about.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Herramienta / Comando para impedir intercambios entre usuario A y B
3 participants