Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next VM id doesn't mean there will be disk available #14

Open
pietrushnic opened this issue Nov 28, 2019 · 3 comments
Open

Next VM id doesn't mean there will be disk available #14

pietrushnic opened this issue Nov 28, 2019 · 3 comments

Comments

@pietrushnic
Copy link

I'm not sure about this assumption, but it looks like vm disk name is generated automatically without checking if it is available:

Error creating machine: Error in driver during machine creation: status code was '500' and error is
500 lvcreate 'pve/vm-100-disk-1' error:   Logical Volume "vm-100-disk-1" already exists in volume group "pve"
notifying bugsnag: [Error creating machine: Error in driver during machine creation: status code was '500' and error is
500 lvcreate 'pve/vm-100-disk-1' error:   Logical Volume "vm-100-disk-1" already exists in volume group "pve"]
++ docker-machine env new-drv-test
Error checking TLS connection: Error checking and/or regenerating the certs: There was an error validating certificates for host "": dial tcp: missing address
You can attempt to regenerate them using 'docker-machine regenerate-certs [name]'.
Be advised that this will trigger a Docker daemon restart which might stop running containers.
@lnxbil
Copy link
Owner

lnxbil commented Nov 29, 2019

Yes, I also encountered this if the previous run failed somehow.

The question is how to react:

  • abort (as of now, but maybe with a nicer error message)
  • remove the disk in case of an error while creating (only applies to errors directly resulting from running the driver, not from having a disk coincidentally)
  • remove the disk and create a new one

I really don't know. Safest approach is to abort and let the human decide if it's save to remove it?

@pietrushnic
Copy link
Author

@lnxbil I'm not proxmox expert, can't we use other disk or increase vmid to generate next free?

@lnxbil
Copy link
Owner

lnxbil commented Nov 29, 2019

@lnxbil I'm not proxmox expert, can't we use other disk or increase vmid to generate next free?

That are also viable options I haven't thought of. Thank you. Using the next free id without a disk is a viable option, I guess. I'll have a look at that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants