Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Meta] Drupal 11 support #764

Open
stephen-cox opened this issue Sep 3, 2024 · 10 comments
Open

[Meta] Drupal 11 support #764

stephen-cox opened this issue Sep 3, 2024 · 10 comments

Comments

@stephen-cox
Copy link
Member

stephen-cox commented Sep 3, 2024

Creating this as a meta issue to track Drupal 11 support.

As discussed at Merge Tuesday, we need to get an idea of how big a job fully supporting Drupal 11 will be. Hopefully, the code should largely support D11 now, so this is likely largely come down to checking contrib support.

Current state of Drupal 11 support:

Dependencies without Drupal 11 support:

Also see https://docs.google.com/spreadsheets/d/1QVDrKtLI1KuAeMfZRQpn0O7nCRX7w7fo0StFHXP58g8/edit?gid=0#gid=0

Issues:

PRs:

@stephen-cox
Copy link
Member Author

stephen-cox commented Sep 3, 2024

@millnut I believe you have started this. Can you add an update on how far you've got with this?

I'll find some time to look at this, but I don't want to duplicate work that has been done so far.

@millnut
Copy link
Member

millnut commented Sep 3, 2024

Yep sure I've got all this compiled and should be able to post something for discussion.

As you mentioned @stephen-cox the biggest problem is where contrib modules have two versions, one for D10 and one for D11

@millnut
Copy link
Member

millnut commented Sep 4, 2024

@stephen-cox I've added a 4.x branch for the project which set drupal core to 11 and updates the workflow for just 4.x requirements https://github.com/localgovdrupal/localgov_project/tree/4.x I'm expecting this to fail to start with

@millnut
Copy link
Member

millnut commented Sep 6, 2024

@stephen-cox here is the file I've been looking at with notes on contrib module changes
https://docs.google.com/spreadsheets/d/1QVDrKtLI1KuAeMfZRQpn0O7nCRX7w7fo0StFHXP58g8/edit?usp=sharing be good if we can upload to Google Docs so we can collab on it

@stephen-cox
Copy link
Member Author

Thanks @millnut for the spreadsheet.

Looking at this it looks like the main D11 upgrade is blocked by the following contrib modules:

There are other contrib dependencies blocking upgrades to some of the other modules, but these are included by default.

We either need to wait for D11 support to be added to these modules or agree a workaround for them.

@millnut
Copy link
Member

millnut commented Sep 10, 2024

Thanks for looking through @stephen-cox I might look at contributing some patches on drupal.org for those and see if they get picked up

@finnlewis finnlewis pinned this issue Sep 19, 2024
@markconroy
Copy link
Member

markconroy commented Sep 19, 2024

@stephen-cox
Copy link
Member Author

stephen-cox commented Oct 18, 2024

Looks like we're now waiting for Drupal 11 support in:

All required by paragraphs.

@millnut
Copy link
Member

millnut commented Dec 6, 2024

I have updated the first post and the spreadsheet with the latest contrib module compatibility

@millnut
Copy link
Member

millnut commented Dec 31, 2024

Existing installs using composer aliases for D11 support is making progress and composer installs work (see localgovdrupal/localgov_shared_workflows#19 (comment)) just need to update our modules and wait for fontawesome and image_widget_crop to tag releases as these are the main blockers. For testing we are blocked waiting for a new release of caxy/php-htmldiff but that is specifically for PHP 8.4 testing (have patched for now).

Composer aliases so far;

"localgovdrupal/localgov"
"localgovdrupal/localgov_core"
"localgovdrupal/localgov_demo"
"localgovdrupal/localgov_directories"
"localgovdrupal/localgov_events"
"localgovdrupal/localgov_geo"
"localgovdrupal/localgov_guides"
"localgovdrupal/localgov_news"
"localgovdrupal/localgov_page_components"
"localgovdrupal/localgov_paragraphs"
"localgovdrupal/localgov_services"
"localgovdrupal/localgov_step_by_step"
"localgovdrupal/localgov_subsites"
"localgovdrupal/localgov_workflows"

The remaining one is uninstalled by default but part of core is localgov_openreferral which needs quite a bit of work. Who maintains this one now?

We can start reviewing these WIP D11 PRs, merging, and creating releases on low-impact ones.

New/Clean installs and installs via Drush there is still some work to do on module core version compatibility as well as the contrib modules above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants