Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty <p> tags in quick facts section #608

Closed
sgroi-l opened this issue Sep 19, 2024 · 1 comment
Closed

Empty <p> tags in quick facts section #608

sgroi-l opened this issue Sep 19, 2024 · 1 comment
Assignees

Comments

@sgroi-l
Copy link

sgroi-l commented Sep 19, 2024

Description

The "Quick Fact" section on the service page contains empty <p> tags. These empty tags do not contribute to the content and should be removed to clean up the markup.

Expected Behaviour

  • HTML markup should be clean and free of unnecessary empty tags.
  • Empty <p> tags should be removed to improve readability and maintainability of the code.

Actual Behaviour

  • The "Quick Fact" section includes empty <p> tags that do not contain any text or content.

How to Replicate

  1. Visit the service page, such as this example page.
  2. Inspect the HTML markup of the "Quick Fact" section.
  3. Locate and verify the presence of empty <p> tags within the section.

Code Snippet

<div class="field field--name-label field--type-string field--label-hidden field__item">quick fact</div>
<div class="field field--name-paragraphs field--type-entity-reference-revisions field--label-hidden field__item">
  <p class="fact-box__opening">Quick Fact example</p>
  <div class="fact-box__fact">
    <p></p> <!-- Empty <p> tag -->
    <div class="field field--name-localgov-fact field--type-string field--label-hidden field__item">9 out of 10 councils prefer LocalGov Drupal!</div>
    <p></p> <!-- Empty <p> tag -->
  </div>
  <p class="fact-box__closing"> Source: the internet</p>
</div>
@sgroi-l sgroi-l changed the title Empty <p> Tags in Quick Facts Section Empty <p> tags in quick facts section Sep 19, 2024
@markconroy markconroy self-assigned this Sep 19, 2024
@markconroy
Copy link
Member

I think this is fixed via #617

Closing. Please re-open if issue persists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants