Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add styling to the contact component #421

Open
Adnan-cds opened this issue Dec 15, 2020 · 6 comments · May be fixed by #695
Open

Add styling to the contact component #421

Adnan-cds opened this issue Dec 15, 2020 · 6 comments · May be fixed by #695
Assignees

Comments

@Adnan-cds
Copy link
Contributor

The Contact Page component is currently not styled.

For an example of how this should appear when styled, please look for the Corporate Commissioning and Procurement team's Contact details at the bottom of this page.

FAO @cjstevens78 @finnlewis @willguv

@keelanfh keelanfh transferred this issue from localgovdrupal/localgov_theme Mar 27, 2023
@keelanfh
Copy link
Member

I made a start on this, we have some CSS for it, but I gave up because it needs a twig template as well, which it doesn't have yet.

@markconroy markconroy self-assigned this Jul 7, 2023
@willguv
Copy link
Member

willguv commented May 22, 2024

@markconroy maybe something to check and fix

@willguv willguv moved this to Refine in 2024 Mission: Refresh May 22, 2024
@markconroy markconroy changed the title Contact card styling Add some styling to the contact component Nov 15, 2024
@willguv willguv moved this to 2025 'Refresh' mission in 2024 Mission: Refresh Nov 27, 2024
@willguv willguv changed the title Add some styling to the contact component Add styling to the contact component Nov 27, 2024
@willguv willguv moved this from 2025 'Refresh' mission to In Progress - Everyone else in 2024 Mission: Refresh Dec 19, 2024
@willguv
Copy link
Member

willguv commented Dec 19, 2024

@clearspotmedia hi Dave, can you share the work you've done for D&G please

@markconroy markconroy linked a pull request Dec 19, 2024 that will close this issue
2 tasks
@willguv
Copy link
Member

willguv commented Jan 22, 2025

Hi @clearspotmedia could you share your design work for this please? Many thanks. Copying @markconroy

@markconroy
Copy link
Member

markconroy commented Jan 22, 2025

@willguv There's a before/after set of screenshots in the PR for the work I have done on this.

I think what I have done might be enough. I looked at Dave's designs over the Christmas break and I think the layout of them is quite specific and wouldn't suit the very generic approach we need to take in LGD so that it's easy for council's to override our designs to make them very specific (like in Dave's designs).

It's one of those trade-offs you make so that custom designs are easy to implement.

@clearspotmedia
Copy link

@willguv @markconroy examples in the PR look like a vast improvement,
2 col layout is there now and as Mark says councils can break out of it if they want to. Thumbs up from me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress - Everyone else
Development

Successfully merging a pull request may close this issue.

5 participants