Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds feedback form #92

Open
wants to merge 6 commits into
base: 1.x
Choose a base branch
from
Open

adds feedback form #92

wants to merge 6 commits into from

Conversation

markconroy
Copy link
Member

Closes #91

What does this change?

Adds a new form for a simple feedback widget.

How to test

  • Enable the localgov_forms_feedback_form module
  • Add a block of type "Webform"
  • Select the feedback form as the form you want in the block

Thanks to Big Blue Door for sponsoring my time to work on this.

@markconroy markconroy requested a review from finnlewis September 9, 2024 16:00
@markconroy markconroy mentioned this pull request Sep 9, 2024
@finnlewis
Copy link
Member

Note: @ekes mentioned we want to check what we did to prevent session cookie getting set.

@stephen-cox stephen-cox requested a review from ekes November 5, 2024 12:35
@stephen-cox
Copy link
Member

Discussing at Merge Tuesday - @ekes to double check if there's seesion cookies getting set

@ekes
Copy link
Member

ekes commented Dec 10, 2024

No session cookie being set. Not even on submission.

It sets the cache control header to no-cache on a submission return page. So with cache time in core enabled the page would be like cache-control max-age=86400, public with the form, and it becomes must-revalidate, no-cache, private for the submission response. Which all seems sensible.

There is also no spam control though ;-)

Other non-related concern would be putting something about personal information somewhere, not to be encouraging councils to end up with personal info in the db.

@ekes ekes removed their assignment Dec 10, 2024
@finnlewis finnlewis self-assigned this Dec 10, 2024
@finnlewis
Copy link
Member

@andybroomfield mentions the need for a council to get a DPA (approval from the legal department) before deploying this a form.

@ekes highlights the need to encourage users to NOT submit personal data.

Also - we might be able to include default options to make use of the long term storage and purge results.

@stephen-cox
Copy link
Member

Discussing at Merge Tuesday - perhaps just show a message when enabling the module with a little more detail in the README.

@markconroy
Copy link
Member Author

perhaps just show a message when enabling the module
with a little more detail in the README.

Done, and done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feedback Module
4 participants