Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drupal 10 support #347

Closed
stephen-cox opened this issue Dec 16, 2022 · 11 comments
Closed

Drupal 10 support #347

stephen-cox opened this issue Dec 16, 2022 · 11 comments

Comments

@stephen-cox
Copy link
Member

Issue to track any changes needed to support Drupal 10

@stephen-cox
Copy link
Member Author

stephen-cox commented Sep 5, 2023

Tasks needed for a Drupal 10 alpha release of LocalGov Microsites:

  • 3.x branches for Microsites profile
  • 3.x branches for Microsites project#
  • D10 support for Group Webform
  • D10 support for LocalGov Blogs
  • D10 support for LocalGov Claro
  • D10 support for LocalGov Forms
  • D10 support for LocalGov Page
  • D10 support for Microsites Base
  • D10 support for Microsites Group
  • All tests passing 🤞

@stephen-cox
Copy link
Member Author

stephen-cox commented Sep 5, 2023

The version 3 of microsites installs with:

composer create-project --stability dev localgovdrupal/localgov_microsites_project MY_PROJECT

Next steps are to ensure Drupal installs, update the Github workflows to run the tests against D10 and fix any borked tests.

@finnlewis
Copy link
Member

Nice one @stephen-cox

Do you think we're ready to do an alpha release of the 3.x branch of localgov_microsites_project to encourage testing?

@finnlewis
Copy link
Member

Nice one @stephen-cox

Do you think we're ready to do an alpha release of the 3.x branch of localgov_microsites_project to encourage testing?

Doh, just read the comments above... sorry! Testing things now :)

@finnlewis
Copy link
Member

@stephen-cox trying to get the Drupal site-install working for localgov_microsites. Have you managed it yet?

After deleting a number of permissions from various install config files and some from the calls to hook_localgov_microsites_roles_default(), I've now got the following:

The "node_type" plugin does not exist. Valid plugin IDs for Drupal\Core\Condition\ConditionManager are: domain, group_type, current_theme, request_path, user_role, webform, entity_bundle:block_content, entity_bundle:crop, entity_bundle:geo_entity, ent
ity_bundle:group_relationship, entity_bundle:group, entity_bundle:group_config_wrapper, entity_bundle:group_content_menu, entity_bundle:localgov_directories_facets, entity_bundle:media, entity_bundle:menu_link_content, entity_bundle:node, entity_bundl
e:taxonomy_term, entity_bundle:webform_submission, entity_bundle:paragraph

Any ideas?

@stephen-cox
Copy link
Member Author

stephen-cox commented Sep 8, 2023

Any ideas?

Yep - plugin id for our block visibility settings needed updating: https://drupal.stackexchange.com/questions/316150/drupal-component-plugin-exception-pluginnotfoundexception-the-node-type-plugi

@stephen-cox
Copy link
Member Author

An update on what's left to do for the Drupal 10 alpha release:

Fix tests on:

Releases for:

There are 2 PRs for the final releases once the above it done:

@stephen-cox
Copy link
Member Author

Latest update on Drupal 10 support:

There are now 2 PRs ready for review adding Drupal 10 support to Microsites Group (localgovdrupal/localgov_microsites_group#420) and Forms (localgovdrupal/localgov_forms#43).

Once they're approved we'll need to coordinate the 3.0.0-alpha1 releases as composer references will need updating after each release.

I'm happy to say we're almost there.

@stephen-cox
Copy link
Member Author

stephen-cox commented Sep 29, 2023

We're ready for an Alpha release!

The following needs to happen in order:

  1. 3.0.0-alpha1 release of Microsites Group Release 3.0.0-alpha1 localgov_microsites_group#420
  2. Update the Composer reference in the Microsites profile to the 3.0.0-alpha1 release of Microsites Group: https://github.com/localgovdrupal/localgov_microsites/blob/3.x/composer.json#L29
  3. 3.0.0-alpha1 release of Microsites Release 3.0.0-alpha1 #401
  4. Update the Composer reference in Microsites project to the 3.0.0-alpha1 release of Microsites: https://github.com/localgovdrupal/localgov_microsites_project/blob/3.x/composer.json#L28
  5. 3.0.0-alpha1 release of Microsites Project Release 3.0.0-alpha1 localgov_microsites_project#31

@hc-konrad hc-konrad unpinned this issue Oct 5, 2023
@finnlewis
Copy link
Member

I think we can close this one. Great work everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants