From 498f9a2fb515f33642e93089fe50fe33647d4068 Mon Sep 17 00:00:00 2001
From: Lee Mills <8024370+millnut@users.noreply.github.com>
Date: Mon, 25 Sep 2023 17:10:54 +0100
Subject: [PATCH 1/3] refactor: lando quality improvements

---
 .lando.dist.yml                    | 19 ++++++++++++++-----
 assets/composer/settings.lando.php | 15 ++++++++++-----
 2 files changed, 24 insertions(+), 10 deletions(-)

diff --git a/.lando.dist.yml b/.lando.dist.yml
index 726f26b..8bc78f4 100644
--- a/.lando.dist.yml
+++ b/.lando.dist.yml
@@ -1,7 +1,6 @@
 name: localgov-micro
 recipe: drupal9
 config:
-  xdebug: false
   webroot: web
   php: '8.1'
 proxy:
@@ -27,6 +26,13 @@ proxy:
     - group-b3.appserver
 services:
   appserver:
+    xdebug: true
+    scanner:
+      retry: 5
+    build_as_root:
+      # This disables Xdebug during build, but puts all dependencies in place
+      # ready for the tooling to enable Xdebug.
+      - rm -f /usr/local/etc/php/conf.d/docker-php-ext-xdebug.ini && /etc/init.d/apache2 reload
     overrides:
       environment:
         DRUSH_OPTIONS_ROOT: '/app/web'
@@ -35,6 +41,9 @@ services:
         MINK_DRIVER_ARGS_WEBDRIVER: '["chrome", { "chromeOptions": { "w3c": false } }, "http://chromedriver:4444/wd/hub"]'
         BROWSERTEST_OUTPUT_DIRECTORY: '/app/web/sites/simpletest/browser_output'
         BROWSERTEST_OUTPUT_BASE_URL: 'https://localgov-micro.lndo.site'
+         # Support debugging CLI with Xdebug.
+        PHP_IDE_CONFIG: "serverName=appserver"
+        XDEBUG_SESSION: "lando"
     build:
       - mkdir -p web/sites/simpletest/browser_output
   database:
@@ -86,11 +95,11 @@ tooling:
     cmd: '/app/bin/phpunit --testdox'
   xdebug-on:
     service: appserver
-    description: Enable xdebug for apache.
-    cmd: "docker-php-ext-enable xdebug && /etc/init.d/apache2 reload"
+    description: Enable Xdebug for Apache.
+    cmd: rm -f /usr/local/etc/php/conf.d/docker-php-ext-xdebug.ini && docker-php-ext-enable xdebug && /etc/init.d/apache2 reload && echo "Xdebug enabled"
     user: root
   xdebug-off:
     service: appserver
-    description: Disable xdebug for apache.
-    cmd: "rm /usr/local/etc/php/conf.d/docker-php-ext-xdebug.ini && /etc/init.d/apache2 reload"
+    description: Disable Xdebug for Apache.
+    cmd: rm -f /usr/local/etc/php/conf.d/docker-php-ext-xdebug.ini && /etc/init.d/apache2 reload && echo "Xdebug disabled"
     user: root
diff --git a/assets/composer/settings.lando.php b/assets/composer/settings.lando.php
index bfbf609..e5690b8 100644
--- a/assets/composer/settings.lando.php
+++ b/assets/composer/settings.lando.php
@@ -130,15 +130,20 @@
  */
 $settings['skip_permissions_hardening'] = TRUE;
 
+/**
+ * Get Lando info
+ */
+$lando_info = json_decode(getenv('LANDO_INFO'), TRUE);
+
 /**
  * Lando database credentials.
  */
 $databases['default']['default'] = array (
-  'database' => 'database',
-  'username' => 'database',
-  'password' => 'database',
-  'host' => 'database',
-  'port' => '3306',
+  'database' => $lando_info['database']['creds']['database'],
+  'username' => $lando_info['database']['creds']['user'],
+  'password' => $lando_info['database']['creds']['password'],
+  'host' => $lando_info['database']['internal_connection']['host'],
+  'port' => $lando_info['database']['internal_connection']['port'],
   'driver' => 'mysql',
   'prefix' => '',
   'collation' => 'utf8mb4_general_ci',

From db1b4aaf35afec5703a1a08aee991f6fb157d489 Mon Sep 17 00:00:00 2001
From: Lee Mills <8024370+millnut@users.noreply.github.com>
Date: Mon, 25 Sep 2023 17:46:47 +0100
Subject: [PATCH 2/3] refactor: lando quality improvements

---
 assets/composer/settings.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/assets/composer/settings.php b/assets/composer/settings.php
index a85db6e..41e56d8 100644
--- a/assets/composer/settings.php
+++ b/assets/composer/settings.php
@@ -770,6 +770,6 @@
 if (file_exists($app_root . '/' . $site_path . '/settings.local.php')) {
   include $app_root . '/' . $site_path . '/settings.local.php';
 }
-elseif (file_exists($app_root . '/' . $site_path . '/settings.lando.php')) {
+elseif (getenv('LANDO_SERVICE_NAME') == 'appserver' && file_exists($app_root . '/' . $site_path . '/settings.lando.php')) {
   include $app_root . '/' . $site_path . '/settings.lando.php';
 }

From 4148ba4e3a4908218cf23cf0b7b1df5298f6b624 Mon Sep 17 00:00:00 2001
From: Lee Mills <8024370+millnut@users.noreply.github.com>
Date: Mon, 25 Sep 2023 18:10:00 +0100
Subject: [PATCH 3/3] refactor: lando quality improvements

---
 .lando.dist.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.lando.dist.yml b/.lando.dist.yml
index 8bc78f4..90f6cb7 100644
--- a/.lando.dist.yml
+++ b/.lando.dist.yml
@@ -1,5 +1,5 @@
 name: localgov-micro
-recipe: drupal9
+recipe: drupal10
 config:
   webroot: web
   php: '8.1'