Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply autosave_form PHP 8.2 patch? #50

Open
opdavies opened this issue Apr 28, 2024 · 0 comments
Open

Apply autosave_form PHP 8.2 patch? #50

opdavies opened this issue Apr 28, 2024 · 0 comments
Assignees
@opdavies

Comments

@opdavies
Copy link
Contributor

After a fresh microsites installation with PHP 8.2, I see this error:

Deprecated function: Creation of dynamic property Drupal\autosave_form\Form\AutosaveFormBuilder::$_serviceId is deprecated in Drupal\Component\DependencyInjection\Container->createService() (line 285 of core/lib/Drupal/Component/DependencyInjection/Container.php).

There's an RTBC-ed issue for it - https://www.drupal.org/project/autosave_form/issues/3355495.

I'm wondering if it would be worth applying the patch to this project to avoid the error as we already have cweagans/composer-patches in composer.json.

Thoughts? @finnlewis
@opdavies opdavies self-assigned this Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@opdavies opdavies

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@opdavies