You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is a followup to #39 and #47.
The issue has come up as we are trying to replace font awesome use on our site with our own icon set.
As far as I can tell this is only a requirement of the submodule localgov_homepage_paragraphs in order to provide the paragraph localgov_ia_block.
Since this is a submodule, do we need the hard requirement to install fontawesome provided by composer.json, could we not move this to composer suggest? (We'd have to add a release note exaplaining that if you use this paragraph type, you need to install this manually to keep it.
Checking the dependancy chain, it's then required by localgov_subsites_paragraphs and then by localgov_subsites.
For the moment, we can disable loading the fontawesome library so it's not a super urgernt deal, but it is another module we are getting installed without really needing it.
So would we be able to remove the dependancy, and would that nessacitate a breaking change needing a major release?
The text was updated successfully, but these errors were encountered:
Note the localgov_ia_block was for creating the icons as seen on the BHCC homepage, which is where I think they originated from, though I think only BHCC implemented using them, not sure how they got tied to Subsites.
I think removing the requirement would require people putting it in the their composer.json
Is this easiest done along with other things that's going to require a version bump... ie along with the D10 upgrade? #113
It depends if they are being used elsewhere, but it would be good to be able to uninstall the module (BHCC switched to SVGs directly). So this could be a porting guide and then a minor version bump that the dependency is being removed. If a council is using font awesome I'd suggest we highlight a manual install. I'd suspect its probabbly common so some co-ordination is required on it's removal, as it's in localgov_paragraphs and not core.
This is a followup to #39 and #47.
The issue has come up as we are trying to replace font awesome use on our site with our own icon set.
As far as I can tell this is only a requirement of the submodule
localgov_homepage_paragraphs
in order to provide the paragraphlocalgov_ia_block
.Since this is a submodule, do we need the hard requirement to install fontawesome provided by composer.json, could we not move this to composer suggest? (We'd have to add a release note exaplaining that if you use this paragraph type, you need to install this manually to keep it.
Checking the dependancy chain, it's then required by localgov_subsites_paragraphs and then by localgov_subsites.
For the moment, we can disable loading the fontawesome library so it's not a super urgernt deal, but it is another module we are getting installed without really needing it.
So would we be able to remove the dependancy, and would that nessacitate a breaking change needing a major release?
The text was updated successfully, but these errors were encountered: