Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabs paragraph doesn't become accordion on smaller devices #12

Open
Adnan-cds opened this issue Dec 14, 2020 · 3 comments
Open

Tabs paragraph doesn't become accordion on smaller devices #12

Adnan-cds opened this issue Dec 14, 2020 · 3 comments

Comments

@Adnan-cds
Copy link
Contributor

Gosia is fixing this in the LocalGov Campaigns module. We need a similar change to Tabs paragraphs bundled with Subsites.

FAO @finnlewis @gosia-mlynarczyk

@markconroy
Copy link
Member

What I'd like to propose here is to stop creating our own solution for tabs and accordions and things and use what is developed by GOVUK instead. I have that running in my own set up and it works really well. If you wish I can add a PR for the tabs templates to use that?

@finnlewis
Copy link
Member

That sounds like a sensible approach @markconroy, I'd love to try it if you can post a pull request.

@markconroy
Copy link
Member

Great. I can do that easily.

Do you think I should open a new PR to add govuk to localgov_skeleton and then a separate PR with the templates for the accordion to this repo? I presume we don't want govuk uk added only to this repo, rather we'd want it available across the board then each repo can use it if they wish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants