Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default Video Paragraph Type Uses View Mode that is Not Configured #30

Open
markconroy opened this issue Apr 13, 2021 · 1 comment
Open
Labels

Comments

@markconroy
Copy link
Member

The Video paragraph type sets the video field to render the remote video media type using the view mode Responsive 3x2.

However, that view mode is not configured for the Remote Video media type, so it defaults back to Default view mode.

Now, Default view mode for remote video media entity just uses the Oembed formatter with no max settings for width or height, so that defaults to 200px x 112px, meaning we have a tiny video on the page.

Following that, we have a template for the video paragraph that just adds a wrapper class around the video to make it responsive (I think - the class is responsive-wrapper), but Drupal core already uses responsive videos out of the box. This template also removes all the default paragraph classes.

I think we should:

  1. Set the video paragraph to render the default view mode for the Remote video
  2. Set the remote video default view mode to use width: 800px and height 450px (so it maintains the aspect ration of YouTube (16:9))
  3. Delete that template and just use the default paragraph template (less to maintain)
  4. Remove the items about video in localgov_subsites_paragraphs.module which I don't think will be needed anymore
@finnlewis
Copy link
Member

Thanks @markconroy - just trying to undetstand this, but it would be good to make the videos render a little larger!

@finnlewis finnlewis added the 3 label Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants