Improve list-secrets to exclude deleted secrets #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
Hey @maxhoheiser @viren-nadkarni |
|
Hello @kaushal540 Thanks for raising this PR. This fork only contains LocalStack-specific patches and is kept in sync with the upstream repo. We do not want this to diverge too much, and besides, submitting it directly to Moto will have a wider impact 🙂 Please submit this contribution to the upstream Moto repo. |
|
Thanks @viren-nadkarni for the guidance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original Issue: localstack/localstack#11635
Description:
This PR addresses an issue where deleted secrets were still being displayed in the list-secrets API response.
Changes:
Modified list-secrets API: The list-secrets API has been modified to filter out deleted secrets by default.
Updated Unit Tests: Unit tests have been updated to verify the correct behavior of the list-secrets API.