Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JtsGeometry.getBuffered doesn't buffer across the dateline #187

Open
tadrinth opened this issue May 21, 2020 · 0 comments
Open

JtsGeometry.getBuffered doesn't buffer across the dateline #187

tadrinth opened this issue May 21, 2020 · 0 comments

Comments

@tadrinth
Copy link

https://github.com/locationtech/spatial4j/blob/master/src/main/java/org/locationtech/spatial4j/shape/jts/JtsGeometry.java#L177

We are using the getBuffered method to find records that are near the record queried. It doesn't buffer across the dateline, though, so if the query record is next to the dateline, we won't find nearby records properly even though they are geographically close to the query record because the buffered geometry stops at the dateline.

There is a TODO to fix this. Any chance of this being improved? The current implementation is better than the homebrew implementation we were using, in that it at least stops at the dateline rather than generating invalid longitudes, so I am very appreciative of the existing work that's gone in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant