Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Footer Component weird behaviour on Android #47

Closed
PopJoestar opened this issue Jun 29, 2024 · 11 comments · Fixed by #48
Closed

Footer Component weird behaviour on Android #47

PopJoestar opened this issue Jun 29, 2024 · 11 comments · Fixed by #48

Comments

@PopJoestar
Copy link

PopJoestar commented Jun 29, 2024

Hello, as the title says the FooterComponent is displayed well on iOS but on Android, it is buggy. Can someone help me?
iOS
simulator_screenshot_DB5CEB35-034E-4668-83EC-0D58622058CA

Android
448802456_801310865439679_3750398373025187280_n

Here is the part of my code for this
Screenshot 2024-06-29 at 16 06 37
d940)

@lodev09
Copy link
Owner

lodev09 commented Jun 29, 2024

Try to use margin instead of bottom on your saveContainer style.

@PopJoestar
Copy link
Author

PopJoestar commented Jun 29, 2024

I have already tried margin and padding but got the same behavior 😔 the only value that worked was bottom: -160 for Android only. Still, this component is a wrapper that I use for every sheet with a Save footer button in my application, and the bottom: -160 only works for a few of those sheets.

@lodev09
Copy link
Owner

lodev09 commented Jun 29, 2024

Can you use simple View instead of GestureHandlerRootView?

@PopJoestar
Copy link
Author

Same behaviour

@lodev09
Copy link
Owner

lodev09 commented Jun 29, 2024

Okay, that's weird... can you try to wrap children with a View? If that doesn't work, please create a reproducible example that I can look at.

@PopJoestar
Copy link
Author

Same behavior. I will give you an example asap

@PopJoestar
Copy link
Author

PopJoestar commented Jun 29, 2024

@lodev09 here you go sir https://github.com/PopJoestar/trusheetExample. On iOS it works like a charm but on Android, the footer doesn't even appear

@lodev09
Copy link
Owner

lodev09 commented Jun 29, 2024

I see the issue. It looks like a regression bug from v0.12

@lodev09
Copy link
Owner

lodev09 commented Jun 29, 2024

PR #48, give it a try and let me know if that fixes your issue. Thanks!

@PopJoestar
Copy link
Author

Thanks for your reactivity, it works well on Android and iOS now 🚀🎉

@a-eid
Copy link

a-eid commented Jun 30, 2024

had this issue today, works perfectly after the upgrade, thank you @lodev09

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants