Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autosave settings after settings value are changed #848

Closed
zeroliu opened this issue Nov 25, 2024 · 1 comment · Fixed by #874
Closed

Autosave settings after settings value are changed #848

zeroliu opened this issue Nov 25, 2024 · 1 comment · Fixed by #874
Assignees

Comments

@zeroliu
Copy link
Contributor

zeroliu commented Nov 25, 2024

Is your feature request related to a problem? Please describe.
Users must click "save and reload" after changing the settings, which is easy to forget. Most obsidian settings are autosaved after each change.

Describe the solution you'd like
Make copilot settings autosave.

Describe alternatives you've considered
Warn users when unsaved changes are detected. But autosave is more intuitive.

Additional context
I discussed this offline with @logancyang. A few modules need to be reset when a value changes. I need to verify that they work as intended and pick up the new settings after the change.

@zeroliu
Copy link
Contributor Author

zeroliu commented Nov 25, 2024

I can take a stab

@logancyang logancyang moved this to Ready in Copilot Kanban Nov 25, 2024
@logancyang logancyang linked a pull request Nov 28, 2024 that will close this issue
@github-project-automation github-project-automation bot moved this from Ready to Done in Copilot Kanban Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants