feat(schemas): add saml_application_configs table
#6817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darcyYe
requested review from
simeng-li,
wangsijie and
gao-sun
as code owners
COMPARE TO
|
| Name | Diff |
|---|---|
| packages/schemas/alterations/next-1731904029-add-saml-application-configs-table.ts | 📈 +1.13 KB |
| packages/schemas/src/foundations/jsonb-types/index.ts | 📈 +47 Bytes |
| packages/schemas/src/foundations/jsonb-types/saml-application-configs.ts | 📈 +616 Bytes |
| packages/schemas/tables/saml_application_configs.sql | 📈 +802 Bytes |
darcyYe
force-pushed
the
yemq-log-10113-add-saml-application-proxies-table
branch
from
3272ad1 to
c1b10ae
Compare
darcyYe
changed the base branch from
yemq-log-10133-add-isVisible-to-applications-table
to
yemq-log-7205-add-saml-application-secrets-table
darcyYe
force-pushed
the
yemq-log-10113-add-saml-application-proxies-table
branch
from
c1b10ae to
75e7def
Compare
darcyYe
changed the title
saml_application_proxies tablesaml_application_configs table
darcyYe
force-pushed
the
yemq-log-7205-add-saml-application-secrets-table
branch
from
9543eb7 to
f3d1c51
Compare
darcyYe
force-pushed
the
yemq-log-10113-add-saml-application-proxies-table
branch
2 times, most recently
from
d129075 to
61399b8
Compare
darcyYe
force-pushed
the
yemq-log-7205-add-saml-application-secrets-table
branch
from
f3d1c51 to
47dd64b
Compare
darcyYe
force-pushed
the
yemq-log-10113-add-saml-application-proxies-table
branch
from
61399b8 to
97dfb47
Compare
simeng-li
reviewed
Nov 20, 2024
packages/schemas/src/foundations/jsonb-types/saml-application-configs.ts
Outdated
Show resolved
Hide resolved
darcyYe
force-pushed
the
yemq-log-7205-add-saml-application-secrets-table
branch
from
47dd64b to
2d7fae3
Compare
darcyYe
force-pushed
the
yemq-log-10113-add-saml-application-proxies-table
branch
from
97dfb47 to
c28b5dc
Compare
darcyYe
force-pushed
the
yemq-log-10113-add-saml-application-proxies-table
branch
from
e59349e to
5554cf6
Compare
darcyYe
force-pushed
the
yemq-log-10113-add-saml-application-proxies-table
branch
from
5554cf6 to
4e3a6a6
Compare
darcyYe
force-pushed
the
yemq-log-7205-add-saml-application-secrets-table
branch
from
2d7fae3 to
7d8cc8d
Compare
darcyYe
force-pushed
the
yemq-log-10113-add-saml-application-proxies-table
branch
from
4e3a6a6 to
57a1561
Compare
darcyYe
force-pushed
the
yemq-log-7205-add-saml-application-secrets-table
branch
from
7d8cc8d to
4de3026
Compare
Base automatically changed from
yemq-log-7205-add-saml-application-secrets-table
to
master
November 21, 2024 11:30
darcyYe
force-pushed
the
yemq-log-10113-add-saml-application-proxies-table
branch
from
57a1561 to
6faece8
Compare
simeng-li
reviewed
Nov 22, 2024
packages/schemas/src/foundations/jsonb-types/saml-application-configs.ts
Show resolved
Hide resolved
darcyYe
deleted the
yemq-log-10113-add-saml-application-proxies-table
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
add
saml_application_configstableWe made
entity_idandacs_urlnullable because:saml_application_configsand SAML apps.saml_application_configs, we would need to determine, based on the DB state at that time, when to insert asaml_application_configsrecord. If these fields are not nullable, for a particular SAML app, when the SAML config record does not exist, it would be impossible to use the patch API to modify one of these fields individually.Testing
Covered by CI.
Checklist
.changeset