Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve lokalise api error handling #30

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Improve lokalise api error handling #30

wants to merge 1 commit into from

Conversation

TheLevti
Copy link
Contributor

  • Chain exceptions so debugging is easier and we know exactly what went wrong.
  • Attach the response object whenever available when throwing an api exception. Clients may be interested in further processing the response object. Currently the LokaliseApiException swallows the original exception and response.

@TheLevti
Improve lokalise api error handling
3ecde6c 
- Chain exceptions so debugging is easier and we know exactly what went wrong.
- Attach the response object when ever available when throwing an api exception.
@specialtactics
Copy link

Really good changes, can this be merged please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TheLevti @specialtactics