Skip to content

Latest commit

 

History

History
29 lines (18 loc) · 1.41 KB

cran-comments.md

File metadata and controls

29 lines (18 loc) · 1.41 KB
Raw

Resubmission Note

UPDATE: The original resubmission did not fix a valgrind error. We have reproduced the error and fixed it.

This is a resubmission, fixing issues with "clang-UBSAN", "gcc-UBSAN", and "valgrind". We have reproduced the errors using the Docker images rocker/r-devel-san, and made the necessary changes.

There are also two failing unit tests on noLD. We believe these to be cause be differences in floating point numbers, since the test expectations are based on values after running thousands of steps of an MCMC algorithm. We have added testthat::skip_on_cran() to the two tests in question.

Test Environments

  • Local Ubuntu 22.04, R 4.3.2, running R CMD check with --use-valgrind option.
  • Local Ubuntu 23.04 with R 4.3.2 built from source with option "--with-valgrind-instrumentation=2", running R CMD check with --use-valgrind option.
  • r-devel-san via rocker/r-devel-san, running R CMD check with --use-valgrind option.
  • r-devel-san via rocker/r-devel-san.
  • local Windows install, R 4.3.2.
  • windows, devel, release and old-release.
  • R-CMD-check via GitHub Actions on windows-latest, macOS-latest, ubuntu-20.04 (release), and ubuntu-20.04 (devel).
  • M1 builder.

R CMD CHECK results

We got

0 NOTEs, 0 WARNINGs, 0 ERRORs.

Downstream Dependencies

The package has one downstream dependency, the package PlackettLuce. This package is not affected by this change, as it does not use any of its functions.