Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme states wrong arguments for 'before.lory.slide' event #607

Open
silllli opened this issue Mar 13, 2017 · 3 comments
Open

Readme states wrong arguments for 'before.lory.slide' event #607

silllli opened this issue Mar 13, 2017 · 3 comments
Assignees

Comments

@silllli
Copy link

silllli commented Mar 13, 2017

The readme file states that the arguments of the 'before.lory.slide' event are

currentSlide, nextSlide

but actually they are

index, nextSlide

@nstanard nstanard self-assigned this Jun 28, 2017
@andrewsulisthio
Copy link

Thanks! I've struggled with this issue for hours until I found this post and change my e.detail.currentslide to e.detail.index specifically for before.lory.slide.

@membla
Copy link

membla commented Jan 14, 2018

Also when infinite is true, the wrong values are returned – the elements added for wrapping are included in the index and currentslide.

@VangelisAlSghir
Copy link

Also when infinite is false, still wrong values are returned. NextSlide shows -1 on "next" click.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants