Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation support needed! #193

Open
louis-e opened this issue Jan 6, 2025 · 17 comments
Open

Translation support needed! #193

louis-e opened this issue Jan 6, 2025 · 17 comments
Labels
discussion help wanted Extra attention is needed

Comments

@louis-e
Copy link
Owner

louis-e commented Jan 6, 2025

Hi there!
With #186 I introduced the support for several languages in the GUI.
Before including this in a release, I still need some more feedback from native speakers. If you speak either Russian, Spanish, Ukrainian, Chinese, or any other language that you think would be good to have Arnis translated into, please check out the according localization file in https://github.com/louis-e/arnis/tree/main/gui-src/locales and provide me some feedback.

Please use en.json as reference for the translation. Your feedback can either be submitted directly as a pull request or as a comment in this issue.

Thanks a lot! :)

@louis-e louis-e added discussion help wanted Extra attention is needed labels Jan 6, 2025
@louis-e louis-e pinned this issue Jan 6, 2025
@lithiumjs
Copy link

Skimmed through the Russian translation, a couple notes:

  • Most Russians won't understand what "lat" or "lng" means; I suggest using "шир" and "дол" or even the full "широта" and "долгота".
  • In new_version_available the last "её" sounds awkward and I think you can just remove it and it'll look better. Just a nitpick though, doesn't affect things too much.

I'll take a closer look in a few hours once I'm able to run the program proper to check cohesion.

Also, invalid_format_error and coordinates_out_of_range seem to be duplicates of invalid_format and error_coordinates_out_of_range respectively.

@mykhailo-25
Copy link

mykhailo-25 commented Jan 6, 2025

I reviewed the Ukrainian translation. Among the errors I found were:

  1. "Обрати місцезнахождення" > "Обрати місцезнаходження" ("Обрати локацію").
    And also the word "місцезнахоення" does not correspond to the norms of the Ukrainian literary language. It can be replaced by "локація" (location), "місце" (place), "розташування" (location) and others. The same in other points.

  2. "Збільште масштаб и оберіть свою область" > "Збільште масштаб і оберіть свою область".
    It is also better to make a direct translation from English, where it is more precisely said what needs to be done: "Збільште масштаб і оберіть область за допомогою прямокутника".

  3. As mentioned in the comment above, in Ukrainian, also need to replace "lat" and "lon" to "шир" і "дов" (широта, довгота).

  4. "Почти генерацію" >"Почати генерацію"

  5. "Користувальницький вибір підтврджено!" > "Користувацький вибір підтверджено!"

  6. "Невірний формат. Будь ласка, використовуйте 'lat,lng,lat,lng' або 'lat lng lat lng" > "Некоректний/неправильний/помилковий (synonyms) формат...".
    "Невірний" can be a man who cheats on his wife, and the format is "некоректний" or "неправильний" or "помилковий".

  7. "Користувальницька обмежувальна рамка:" > "Користувацька обмежувальна рамка:"

  8. "Обрати існуючий світ" > "Обрати наявний світ" or "Обрати світ, що існує".
    The word "існуючий" does not correspond to the norms of the Ukrainian language and is a tracing from russian.

  9. "Customization Settings" is more appropriate to translate as "Налаштування параметрів" or simply "Параметри" or "Налаштування".

  10. "Доступна нова версія! Натисніть тут, щоб скачати її" > Доступна нова версія! Натисніть тут, щоб завантажити її".
    "Скачати" in Ukrainian means "turning, turning over, giving something a rounded, spherical shape", it is better to replace it with "завантажити".

  11. "Вибраний світ в даний час використовується" > "Вибраний світ зараз використовується".

  12. "Процес генерації почато" > "Процес генерації розпочато".

  13. "Тайм-аут заливки (сек):" > "Тайм-аут заповнення (сек):"
    As far as I understand, "floodfill_timeout" is an error that occurs when a large world is filled for too long and execution stops. Therefore, it is better to replace the word "заливки" with "заповнення", because "заливка" is a graphic process, for example, filling the canvas with color.

ua.json

@lithiumjs
Copy link

lithiumjs commented Jan 6, 2025

As far as I understand, "floodfill_timeout" is an error that occurs when a large world is filled for too long and execution stops. Therefore, it is better to replace the word "заливки" with "заповнення", because "заливка" is a graphic process, for example, filling the canvas with color.

From what I know, English "floodfill" is actually related to the graphic process you described. You know how in MS Paint, if you use the paint bucket tool on a not-completely-enclosed area it fills the entire screen? That's floodfilling gone wrong. Arnis does a similar thing here, so I think "заливка" should be fine in this case.

@louis-e
Copy link
Owner Author

louis-e commented Jan 6, 2025

Thanks a lot for your effort, you both! Will be included in the next release :)

@Ilya114
Copy link
Contributor

Ilya114 commented Jan 6, 2025

@mykhailo-25 thanks for fixes for ukr translation

@lithiumjs
Copy link

lithiumjs commented Jan 6, 2025

I should've clarified: in error_coordinates_out_of_range the correct phrasing would be "широта перед долготой". Grammatical cases, man!

Something similar has to be done for Ukrainian, but I'll leave it to Mykhailo here to provide the accurate version.

@MrHacker117
Copy link

Here is the translation for Swedish:
se.json

@MrHacker117
Copy link

Here is the translation for the Korean language:
kr.json

@Nico-RF
Copy link

Nico-RF commented Jan 7, 2025

As for es.json, in the floodfill_timeout function I'd rather translate "Floodfill" as "relleno", not "inundación". This latter term refers to a literal water flood in Spanish. The proper terminology would be "relleno" as an implicit action of "flooding the creation of the world". "Relleno" means "filling" , so that's it. :D

PS: The rest of the Spanish translation in es.json is neat. I'm loving how this project's coming out, keep up with the good work!! :]

@louis-e
Copy link
Owner Author

louis-e commented Jan 7, 2025

Thanks a lot everyone, I added those changes - they'll be in the next release!

@TheComputerGuy96
Copy link
Contributor

#289 contains some extra strings (so hopefully people can translate these too)

@makhlwf
Copy link

makhlwf commented Jan 15, 2025

Hi, I have submitted a pull request (#291) to address this issue by adding Arabic localization. Please take a look and review it at your convenience. Let me know if any changes are needed. Thank you!

@TheComputerGuy96
Copy link
Contributor

@makhlwf #287 already has an Arabic language translation (so you should probably review it to see what's wrong there)

@makhlwf
Copy link

makhlwf commented Jan 15, 2025

@makhlwf #287 already has an Arabic language translation (so you should probably review it to see what's wrong there)

Hello, @TheComputerGuy96 I haven't seen this before. After reviewing it, there are some suggestions or edits that can be made to it. Do you suggest deleting my poll request and comment on it with my suggestions?

@TheComputerGuy96
Copy link
Contributor

@makhlwf You can just close yours (with a message it's a duplicate)

@theemirkocak
Copy link

Is it okay to put some jokes like "Alright there it is" or do you just need it simple. I am willing to translate it to turkish.

@louis-e
Copy link
Owner Author

louis-e commented Jan 18, 2025

I'd prefer it to stay formal! :) @theemirkocak

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

9 participants