Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape whitespace in build script #84

Open
thetw opened this issue Jan 28, 2021 · 1 comment
Open

Escape whitespace in build script #84

thetw opened this issue Jan 28, 2021 · 1 comment

Comments

@thetw
Copy link

thetw commented Jan 28, 2021

I'm running into an issue when trying to use the build script on macOS.
My home folder is located on a non-standard location and the drives name includes whitespace.

$ echo $PWD         
/Volumes/Storage SSD/Users/thetw/Desktop/sharp-libvips

When i try to run the build script, every command that involves the unescaped absolute path to the build folder results in errors like:

mkdir: /Volumes/Storage: Permission denied
mkdir: SSD/Users/thetw/Desktop/sharp-libvips/build: No such file or directory

As you can see the unescaped path got split at the whitespace character which obviously creates invalid paths.

Do you have a clue how we could fix that? The only way that came to my mind so far is to properly escape all occurrences of the path invocations in the build script with " or '... or do i miss something?

@lovell
Copy link
Owner

lovell commented Jan 29, 2021

Hi, I'd be happy to accept a PR that add quotes around filesystem paths.

As a possible workaround for now, you might be able to create a symlink without a space.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants