Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DV] Prerequisites for bitmanip DV #703

Closed
3 tasks done
imphil opened this issue Mar 13, 2020 · 5 comments
Closed
3 tasks done

[DV] Prerequisites for bitmanip DV #703

imphil opened this issue Mar 13, 2020 · 5 comments
Labels
Component:DV Design verification (DV) or testing issue Type:Enhancement Feature requests, enhancements

Comments

@imphil
Copy link
Contributor

imphil commented Mar 13, 2020 •
edited by vogelpi
Loading

We are making progress on implementing the bitmanip (B) extension in Ibex in #89. This issue tracks things we need to have before we can start DV work on it.
@imphil imphil added Type:Enhancement Feature requests, enhancements Component:DV Design verification (DV) or testing issue labels Mar 13, 2020
@imphil
Copy link
Contributor Author

imphil commented Mar 13, 2020

@taoliug @udinator what are the plans for bitmanip in riscv-dv?

@udinator
Copy link
Contributor

In riscv-dv, we've had a PR (chipsalliance/riscv-dv#498) opened by an external contributor to add most of the support for B-extension instructions. @weicaiyang is going to help with merging this PR into the codebase soon, and then I will take over B-extension verification for Ibex from there.

imphil added a commit to imphil/ibex that referenced this issue Mar 23, 2020
@imphil
Update GCC to include bitmanip patches
01e76f6 
Use a toolchain in CI which has support for experimental bitmanip
patches. This toolchain is based on GCC 9.2.0 with additional bitmanip
patches, and reports itself as 10.0 experimental.

The toolchain was prepared by Luís Marques in
lowRISC/lowrisc-toolchains#11. Thanks!

Addresses part of lowRISC#703
@imphil imphil mentioned this issue Mar 23, 2020
Merged
@imphil
Copy link
Contributor Author

imphil commented Mar 23, 2020

An updated compiler toolchain is available in CI after #724 is merged. If you want to manually get one, download a release 20200323-1 or newer from https://github.com/lowRISC/lowrisc-toolchains/releases.

imphil added a commit that referenced this issue Mar 24, 2020
@imphil
Update GCC to include bitmanip patches
bdfe8de 
Use a toolchain in CI which has support for experimental bitmanip
patches. This toolchain is based on GCC 9.2.0 with additional bitmanip
patches, and reports itself as 10.0 experimental.

The toolchain was prepared by Luís Marques in
lowRISC/lowrisc-toolchains#11. Thanks!

Addresses part of #703
vogelpi added a commit to vogelpi/ibex that referenced this issue Apr 23, 2020
@vogelpi
[dv] Enable verification of B-extension with OVPsim and Spike
d205a49 
This is related to lowRISC#703.

Signed-off-by: Pirmin Vogel <[email protected]>
vogelpi added a commit to vogelpi/ibex that referenced this issue Apr 23, 2020
@vogelpi
[dv] Enable verification of B-extension with OVPsim and Spike
191de44 
This is related to lowRISC#703.

Signed-off-by: Pirmin Vogel <[email protected]>
vogelpi added a commit to vogelpi/ibex that referenced this issue Apr 23, 2020
@vogelpi
[dv] Enable verification of the Bitmanip Extension with OVPsim and Spike
fa0f1ff 
This is related to lowRISC#703.

Signed-off-by: Pirmin Vogel <[email protected]>
@vogelpi vogelpi mentioned this issue Apr 23, 2020
Merged
@vogelpi
Copy link
Contributor

vogelpi commented Apr 23, 2020

FYI: I have tested the Bitmanip support in Spike and RISCV-DV. The linked PR enables it and adds a tests for Ibex.

What is missing is support for functional coverage for the B instructions. But people are working on that upstream (RISCV-DV).

vogelpi added a commit to vogelpi/ibex that referenced this issue Apr 24, 2020
@vogelpi
[dv] Enable verification of the Bitmanip Extension with OVPsim and Spike
d071c58 
This is related to lowRISC#703.

Signed-off-by: Pirmin Vogel <[email protected]>
vogelpi added a commit to vogelpi/ibex that referenced this issue Apr 27, 2020
@vogelpi
[dv] Enable verification of the Bitmanip Extension with OVPsim and Spike
de35d27 
This is related to lowRISC#703.

Signed-off-by: Pirmin Vogel <[email protected]>
vogelpi added a commit to vogelpi/ibex that referenced this issue Apr 27, 2020
@vogelpi
[dv] Enable verification of the Bitmanip Extension with OVPsim and Spike
102151d 
This is related to lowRISC#703.

Signed-off-by: Pirmin Vogel <[email protected]>
vogelpi added a commit that referenced this issue Apr 27, 2020
@vogelpi
[dv] Enable verification of the Bitmanip Extension with OVPsim and Spike
8bd0423 
This is related to #703.

Signed-off-by: Pirmin Vogel <[email protected]>
@vogelpi
Copy link
Contributor

vogelpi commented Jul 3, 2020

Spike/OVPSim support for bitmanip can be enabled and we documented how to do this. RISCV-DV has support for bitmanip support.

I think we are done here, WDYT @imphil ?

@imphil imphil closed this as completed Jul 3, 2020
ganoam pushed a commit to ganoam/ibex that referenced this issue Dec 30, 2020
@vogelpi @ganoam
[dv] Enable verification of the Bitmanip Extension with OVPsim and Spike
9f2cc0e 
This is related to lowRISC#703.

Signed-off-by: Pirmin Vogel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component:DV Design verification (DV) or testing issue Type:Enhancement Feature requests, enhancements
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@imphil @udinator @vogelpi