Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all modifications to core telescope app into a package #31

Open
curioussavage opened this issue Feb 16, 2015 · 1 comment
Open

Comments

@curioussavage
Copy link
Contributor

I finally took time to read through the telescope docs (partially) and I would propose doing this right now to make sure the app can benefit from future updates to telescope.

While this project is still young it is relatively easier to do this.

@lpatmo
Copy link
Owner

lpatmo commented Feb 17, 2015

I have most of the custom additions in cb-theme-pages already; if I remember correctly, the major part where I'll get merge conflicts is in en.i18n.json. I tried adding i18n to the cb-theme-pages folder but it didn't override correctly.

The other place I haven't put into a package yet is this:

users = users.concat(post.upvoters);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants