Migrate from Cubature.jl to HCubature.jl #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #236 +/- ##
==========================================
+ Coverage 83.42% 85.75% +2.32%
==========================================
Files 29 44 +15
Lines 748 1151 +403
==========================================
+ Hits 624 987 +363
- Misses 124 164 +40 ☔ View full report in Codecov by Sentry. |
|
Thanks @DilumAluthge . Indeed licensing issues are relevant, let me merge this and ship it in the next release. |
|
@DilumAluthge Should be released in a few minuts. Do not heistate to reopen this or another issues if it is still not right for you. Thanks :) |
|
@lrnv Thanks so much for the quick merge and new release! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #235
I ran the tests locally on this PR branch, and they passed.