Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Williamson transform sampling #46

Closed
wants to merge 19 commits into from
Closed

Williamson transform sampling #46

wants to merge 19 commits into from

Conversation

lrnv
Copy link
Owner

@lrnv lrnv commented Oct 30, 2023

Fot the moment this implementation is barebone...
We also need documentation and bindings for a few known generators. and a lot of tests.

but otherwise this should work correctly.

In the future, some copulas may leverage this implmentation, in partiuclar the version that provide both the radial dist and the generator (if both are known, better give both).

We would also need the inverswe generator for some functions... maybe it can be provided through another field in the struct ? And/or computed automaticallly..

@lrnv
Copy link
Owner Author

lrnv commented Oct 30, 2023

Exemples from Mcneil+Neshleova where the generator AND the williamson distribution are known analytically could be implemented as exemples

@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Merging #46 (a019663) into main (68bc9e7) will increase coverage by 0.56%.
Report is 14 commits behind head on main.
The diff coverage is 82.27%.

@@            Coverage Diff             @@
##             main      #46      +/-   ##
==========================================
+ Coverage   77.40%   77.97%   +0.56%     
==========================================
  Files          22       23       +1     
  Lines         332      386      +54     
==========================================
+ Hits          257      301      +44     
- Misses         75       85      +10     
Files Coverage Δ
src/ArchimedeanCopula.jl 86.95% <100.00%> (ø)
src/ArchimedeanCopulas/IndependentCopula.jl 81.81% <ø> (+63.63%) ⬆️
src/Copula.jl 100.00% <100.00%> (ø)
src/Copulas.jl 100.00% <ø> (ø)
src/EllipticalCopula.jl 100.00% <100.00%> (ø)
src/MiscellaneousCopulas/EmpiricalCopula.jl 0.00% <ø> (ø)
src/MiscellaneousCopulas/MCopula.jl 50.00% <ø> (+16.66%) ⬆️
src/MiscellaneousCopulas/PlackettCopula.jl 94.44% <100.00%> (+0.15%) ⬆️
src/MiscellaneousCopulas/WCopula.jl 25.00% <ø> (ø)
src/SklarDist.jl 100.00% <ø> (ø)
... and 9 more

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Copy link
Owner Author

@lrnv lrnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dont we need one more exponential to sample from de d-variate simplex ? I though so.

lrnv and others added 6 commits October 31, 2023 12:43
Bumps [actions/checkout](https://github.com/actions/checkout) from 2 to 4.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v2...v4)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 2 to 3.
- [Release notes](https://github.com/codecov/codecov-action/releases)
- [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md)
- [Commits](codecov/codecov-action@v2...v3)

---
updated-dependencies:
- dependency-name: codecov/codecov-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@lrnv lrnv closed this Nov 6, 2023
@lrnv
Copy link
Owner Author

lrnv commented Nov 6, 2023

Closed in favor of #51

@lrnv lrnv deleted the williamson branch November 8, 2023 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant