Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic aliasing of archimedeans #82

Merged
merged 4 commits into from
Nov 22, 2023
Merged

Automatic aliasing of archimedeans #82

merged 4 commits into from
Nov 22, 2023

Conversation

lrnv
Copy link
Owner

@lrnv lrnv commented Nov 21, 2023

see https://discourse.julialang.org/t/how-to-dispatch-on-a-type-alias/106476/31

I still have an issue at precompilation :

julia> using Copulas
[ Info: Precompiling Copulas [ae264745-0b69-425e-9d9d-cf662c5eec93]
ERROR: LoadError: UndefVarError: `Copulas.AMHGenerator` not defined
Stacktrace:
 [1] top-level scope
   @ c:\Users\lrnv\.julia\dev\Copulas\src\ArchimedeanCopula.jl:84      
 [2] eval
   @ .\boot.jl:370 [inlined]
 [3] top-level scope
   @ c:\Users\lrnv\.julia\dev\Copulas\src\ArchimedeanCopula.jl:83      
 [4] include(mod::Module, _path::String)
   @ Base .\Base.jl:457
 [5] include(x::String)
   @ Copulas c:\Users\lrnv\.julia\dev\Copulas\src\Copulas.jl:1
 [6] top-level scope
   @ c:\Users\lrnv\.julia\dev\Copulas\src\Copulas.jl:69
 [7] include
   @ .\Base.jl:457 [inlined]
 [8] include_package_for_output(pkg::Base.PkgId, input::String, depot_path::Vector{String}, dl_load_path::Vector{String}, load_path::Vector{String}, concrete_deps::Vector{Pair{Base.PkgId, UInt128}}, source::Nothing)
   @ Base .\loading.jl:2049
 [9] top-level scope
   @ stdin:3
in expression starting at c:\Users\lrnv\.julia\dev\Copulas\src\ArchimedeanCopula.jl:80
in expression starting at c:\Users\lrnv\.julia\dev\Copulas\src\Copulas.jl:1
in expression starting at stdin:3
ERROR: Failed to precompile Copulas [ae264745-0b69-425e-9d9d-cf662c5eec93] to "C:\\Users\\lrnv\\.julia\\compiled\\v1.9\\Copulas\\jl_D7EF.tmp".Stacktrace:
  [1] error(s::String)
    @ Base .\error.jl:35
  [2] compilecache(pkg::Base.PkgId, path::String, internal_stderr::IO, 
internal_stdout::IO, keep_loaded_modules::Bool)
    @ Base .\loading.jl:2300
  [3] compilecache
    @ .\loading.jl:2167 [inlined]
  [4] _require(pkg::Base.PkgId, env::String)
    @ Base .\loading.jl:1805
  [5] _require_prelocked(uuidkey::Base.PkgId, env::String)
    @ Base .\loading.jl:1660
  [6] macro expansion
    @ .\loading.jl:1648 [inlined]
  [7] macro expansion
    @ .\lock.jl:267 [inlined]
  [8] require(into::Module, mod::Symbol)
    @ Base .\loading.jl:1611
  [9] eval
    @ .\boot.jl:370 [inlined]
 [10] eval
    @ .\Base.jl:68 [inlined]
 [11] repleval(m::Module, code::Expr, #unused#::String)
    @ VSCodeServer c:\Users\lrnv\.vscode-insiders\extensions\julialang.language-julia-1.60.2\scripts\packages\VSCodeServer\src\repl.jl:229    
 [12] (::VSCodeServer.var"#110#112"{Module, Expr, REPL.LineEditREPL, REPL.LineEdit.Prompt})()
    @ VSCodeServer c:\Users\lrnv\.vscode-insiders\extensions\julialang.language-julia-1.60.2\scripts\packages\VSCodeServer\src\repl.jl:192    
 [13] with_logstate(f::Function, logstate::Any)
    @ Base.CoreLogging .\logging.jl:514
 [14] with_logger
    @ .\logging.jl:626 [inlined]
 [15] (::VSCodeServer.var"#109#111"{Module, Expr, REPL.LineEditREPL, REPL.LineEdit.Prompt})()
    @ VSCodeServer c:\Users\lrnv\.vscode-insiders\extensions\julialang.language-julia-1.60.2\scripts\packages\VSCodeServer\src\repl.jl:193    
 [16] #invokelatest#2
    @ .\essentials.jl:819 [inlined]
 [17] invokelatest(::Any)
    @ Base .\essentials.jl:816
 [18] macro expansion
    @ c:\Users\lrnv\.vscode-insiders\extensions\julialang.language-julia-1.60.2\scripts\packages\VSCodeServer\src\eval.jl:34 [inlined]        
 [19] (::VSCodeServer.var"#62#63")()
    @ VSCodeServer .\task.jl:514

julia>

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (f01951c) 80.35% compared to head (d59e173) 80.29%.

Files Patch % Lines
src/ArchimedeanCopula.jl 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #82      +/-   ##
==========================================
- Coverage   80.35%   80.29%   -0.06%     
==========================================
  Files          28       28              
  Lines         682      670      -12     
==========================================
- Hits          548      538      -10     
+ Misses        134      132       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lrnv lrnv merged commit 4b1746d into main Nov 22, 2023
8 checks passed
@lrnv lrnv deleted the automatic_aliasing branch November 22, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant