Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: replace snake case file names with camelCase #316

Closed
wants to merge 2 commits into from
Closed

Fix: replace snake case file names with camelCase #316

wants to merge 2 commits into from

Conversation

Abhinav-Chdhary
Copy link

Motivation and Context

Fixes #68 replacing snake_case with camelCase, for consistency.

Description

Renamed files and imports that were using snake_case

Steps for Testing

Switch to replaceSnakeCaseWithCamel branch and try npm run dev

Screenshots

No change in UI

@dmytropolityka dmytropolityka added deploy:athena-test1 Athena Test Server 1 and removed deploy:athena-test1 Athena Test Server 1 labels Jul 22, 2024
@Abhinav-Chdhary
Copy link
Author

Hi @undernagruzez can you help me understand why these checks failed?

@dmytropolityka
Copy link
Contributor

I suppose the error is related to the origin of the branch, but will check once again later

@FelixTJDietrich
Copy link
Collaborator

Code looks good to me, I merged some code on the playground and this would need to be updated. But this can generally be merged once tested on the test server.

@Abhinav-Chdhary
Copy link
Author

Code looks good to me, I merged some code on the playground and this would need to be updated. But this can generally be merged once tested on the test server.

And how can we do that?

FelixTJDietrich
FelixTJDietrich requested changes Aug 6, 2024
View reviewed changes
Copy link
Collaborator

@FelixTJDietrich FelixTJDietrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'd need to resolve the conflicts, I don't think I can resolve them in the fork.

playground/scripts/artemis/1LoadAnonymizedDatabase_dump.mjs Outdated Show resolved Hide resolved
@FelixTJDietrich
Copy link
Collaborator

It looks like this for me, can you pull from develop and resolve the conflicts?
image

@Abhinav-Chdhary
Copy link
Author

It looks like this for me, can you pull from develop and resolve the conflicts?
Yes I tried that but I got this error. Can you help me understand this?
image

@FelixTJDietrich
Copy link
Collaborator

I don't really now 🤔 you renamed a lot of files by changing from snake_case to camel camelCase and I think git has problems to match it.

@Abhinav-Chdhary
Copy link
Author

I'm sorry, I have picked up a new project. I may try this some time later.

@Abhinav-Chdhary Abhinav-Chdhary deleted the replaceSnakeCaseWithCamel branch August 9, 2024 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FelixTJDietrich FelixTJDietrich FelixTJDietrich requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Playground: Replace snake_case with camelCase
3 participants
@Abhinav-Chdhary @dmytropolityka @FelixTJDietrich