Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/create module programming winnowing #315

Open
wants to merge 87 commits into
base: develop
Choose a base branch
from

Conversation

marlon-luca-bu
Copy link
Contributor

Motivation and Context

This PR introduces a new module winnowing.

Description

Added new module winnowing

Steps for Testing

Start Athena and verify it is working

Screenshots

dependabot bot and others added 30 commits May 10, 2024 01:55
Bumps [next](https://github.com/vercel/next.js) from 13.5.6 to 14.1.1.
- [Release notes](https://github.com/vercel/next.js/releases)
- [Changelog](https://github.com/vercel/next.js/blob/canary/release.js)
- [Commits](vercel/next.js@v13.5.6...v14.1.1)

---
updated-dependencies:
- dependency-name: next
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [mysql2](https://github.com/sidorares/node-mysql2) from 3.9.7 to 3.9.8.
- [Release notes](https://github.com/sidorares/node-mysql2/releases)
- [Changelog](https://github.com/sidorares/node-mysql2/blob/master/Changelog.md)
- [Commits](sidorares/node-mysql2@v3.9.7...v3.9.8)

---
updated-dependencies:
- dependency-name: mysql2
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <[email protected]>
…nd/next-14.1.1' into feature/playground-self-learning-feedback
…nd/mysql2-3.9.8' into feature/playground-self-learning-feedback
Copy link
Member

@maximiliansoelch maximiliansoelch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use only the resources from the winnowing module to avoid the dependencies to the apted module. Also get rid of the added init.py files where they are not required.

athena/pyproject.toml Outdated Show resolved Hide resolved
modules/__init__.py Outdated Show resolved Hide resolved
modules/programming/__init__.py Outdated Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it intended that the generated JavaParser is different than the one in the apt module?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I remember this is because of the different way the winnowing algorithm works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants